Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-12-05 Thread Weijun Wang
The change looks fine to me. Thanks Max > On Dec 4, 2018, at 1:11 AM, Seán Coffey wrote: > > whoops: > latest webrev : http://cr.openjdk.java.net/~coffeys/webrev.8213952.v4/webrev/ > Regards, > Sean.

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-12-05 Thread Chris Hegarty
On Dec 4, 2018, at 1:11 AM, Seán Coffey wrote: whoops: latest webrev : http://cr.openjdk.java.net/~coffeys/webrev.8213952.v4/webrev/ Regards, Sean. Looks good. -Chris.

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2018-12-05 Thread Weijun Wang
I've thought about this over and have the following plan: Since GSSName::isMN is always true, every gss_name_t must be a MN and I decide the name to be always krb5 style and the type to be always NT_KRB5_NAME. However, somewhere in the JGSS native bridge implementation the name and type are cac

Re: RFR(S)JDK-8214074: Ghash optimization using AVX instructions

2018-12-05 Thread Anthony Scarpino
Smita, I did some performance testing on the changes and noticed that while the larger data sizes perform better, there is a drop in the smaller data sizes. 16byte data sizes saw a drop from 2.4m ops/sec to 1.7m ops/sec and 64bytes dropped from 2.1m ops/sec to 1.5m ops/sec. At 256 bytes it

Re: RFR[12] JDK-8214459: NSS source should be removed

2018-12-05 Thread Valerie Peng
Looks good. Thanks, Valerie On 12/3/2018 6:41 PM, sha.ji...@oracle.com wrote: Hi Valerie, Do you have more concern about this issue? I re-generate this patch with hg diff option -g. The new patch should delete all the files, including the directory. diff --git a/test/jdk/sun/security/pkcs1

RFR JDK-8214129: SSL session resumption/SNI with TLS1.2 causes StackOverflowError

2018-12-05 Thread Jamil Nimeh
Hello all, This fix covers an issue where large numbers of TLS 1.2 session resumptions were causing a StackOverflowError to occur.  This was happening because the SSLSessionImpl constructor creates a new unmodifiableList from the SNI list attached to the HandshakeContext.  Since that is also

Re: RFR JDK-7092821 "java.security.Provider.getService() is synchronized and became scalability bottleneck"

2018-12-05 Thread Weijun Wang
Hi Valerie -map.put("CertPathBuilder.PKIX ValidationAlgorithm", -"RFC5280"); -map.put("CertPathValidator.PKIX ValidationAlgorithm", -"RFC5280"); +attrs.put("PKIX ValidationAlgorithm", "RFC5280"); << +add(p, "CertPathBuilder", "

Re: RFR JDK-8214129: SSL session resumption/SNI with TLS1.2 causes StackOverflowError

2018-12-05 Thread Xue-Lei Fan
Hi Jamil, For a defense in depth fix, as you are already there, I may suggest update two more places. ServerNameExtension.java: private CHServerNamesSpec(List serverNames) { this.serverNames = Collections.unmodifiableList(serverNames); } SSLSession