[12] RFR 8215694: keytool cannot generate RSASSA-PSS certificates

2018-12-21 Thread Weijun Wang
Please take a review at https://cr.openjdk.java.net/~weijun/8215694/webrev.00/ This bug reveals several issues: 1. Encoding of the RSASSA-PSS signature algorithm in PKCS10 and X509CertImpl. 2. The missing of setParameter() call for PKCS10 and X509CertImpl. 3. All keytool commands of -genkey

RFR - CSR: 8213082: (zipfs) Add support for POSIX file permissions (was: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions)

2018-12-21 Thread Langer, Christoph
Hi folks, getting back to the topic of adding POSIX file permission support to jdk.zipfs... I think as we are now in the early stages of JDK13, it's a good point in time to get some (hopefully final) activity on that one. In the last review discussions you were asking me to provide some write-u

Re: RFR - CSR: 8213082: (zipfs) Add support for POSIX file permissions (was: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions)

2018-12-21 Thread Alan Bateman
On 21/12/2018 10:41, Langer, Christoph wrote: Hi folks, getting back to the topic of adding POSIX file permission support to jdk.zipfs... I think as we are now in the early stages of JDK13, it's a good point in time to get some (hopefully final) activity on that one. In the last review discus

RE: RFR - CSR: 8213082: (zipfs) Add support for POSIX file permissions (was: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions)

2018-12-21 Thread Langer, Christoph
Hi Alan, > Adding support for POSIX file permissions to the zip APIs is problematic > as we've been discussing here. There are security concerns and also > concerns that how it interacts with JAR files and signed JAR in > particular. I don't disagree that we can come to agreement on zipfs > suppor

Re: RFR 8213400: Support choosing curve name in keytool keypair generation

2018-12-21 Thread Sean Mullan
On 11/26/18 8:32 PM, Weijun Wang wrote: Ping I made a few tweaks to the title and wording. On Nov 15, 2018, at 9:24 AM, Weijun Wang wrote: On Nov 15, 2018, at 3:53 AM, Adam Petcher wrote: This looks good to me, though I made a couple of trivial editorial changes. It's fine as is, bu

RE: RFR 8213031: (zipfs) Add support for POSIX file permissions

2018-12-21 Thread Langer, Christoph
Hi all, here comes the updated webrev: http://cr.openjdk.java.net/~clanger/webrevs/8213031.3/ I've rebased the change to the current state of the JDK depot. Thanks to Volker, the test has been enhanced and now also tests more copy operations (from zip file system to zip file system and from zi

Re: RFR 8213400: Support choosing curve name in keytool keypair generation

2018-12-21 Thread Weijun Wang
> On Dec 21, 2018, at 9:58 PM, Sean Mullan wrote: > > On 11/26/18 8:32 PM, Weijun Wang wrote: >> Ping > > I made a few tweaks to the title and wording. > >>> On Nov 15, 2018, at 9:24 AM, Weijun Wang wrote: >>> >>> >>> On Nov 15, 2018, at 3:53 AM, Adam Petcher wrote: This

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

2018-12-21 Thread Volker Simonis
Hi Christoph, thanks for updating the change. I think it is in a good state now and ready to go! Also the documentation in the CSR for this issue ( https://bugs.openjdk.java.net/browse/JDK-8213082) is greatly appreciated and answers all the questions which have been raised so far. So if there are

Re: RFR - CSR: 8213082: (zipfs) Add support for POSIX file permissions (was: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions)

2018-12-21 Thread Volker Simonis
Hi Alan, thanks for looking at this issue. I've dived into the ZipFS implementation during the last weeks and together with Christoph we've extended and improved both the implementation the test coverage. As Christoph already emphasized, this change is only for improving jdk.nio.zipfs without any

Re: RFR - CSR: 8213082: (zipfs) Add support for POSIX file permissions

2018-12-21 Thread Joe Darcy
Hello, On 12/21/2018 8:43 AM, Volker Simonis wrote: Hi Alan, thanks for looking at this issue. I've dived into the ZipFS implementation during the last weeks and together with Christoph we've extended and improved both the implementation the test coverage. As Christoph already emphasized, this

Re: RFR 8215769: Java cannot probe pkcs12 files exported by Firefox

2018-12-21 Thread Sean Mullan
Looks fine. I think pushing to JDK 13 is fine for now. --Sean On 12/20/18 8:57 PM, Weijun Wang wrote: Please take a review at https://cr.openjdk.java.net/~weijun/8215769/webrev.00/ It's currently P4 because I don't think many people import pkcs12 files from Firefox to Java, and even if s

Re: RFR 8213400: Support choosing curve name in keytool keypair generation

2018-12-21 Thread Sean Mullan
On 12/21/18 9:50 AM, Weijun Wang wrote: I think it is ok to use secp384r1 in the release note even though it is the default for -keysize 384. OK, I'll use it. And I've just added another sentence that we recommend using -groupname. Looks good now. --Sean

Re: RFR 8213400: Support choosing curve name in keytool keypair generation

2018-12-21 Thread Weijun Wang
Thanks for the extra editing. I've updated it to delivered. --Max > On Dec 22, 2018, at 3:51 AM, Sean Mullan wrote: > > On 12/21/18 9:50 AM, Weijun Wang wrote: >>> I think it is ok to use secp384r1 in the release note even though it is the >>> default for -keysize 384. >> OK, I'll use it. And