SSLEngine.wrap(...) returns NOT_HANDSHAKING even when the alert was not consumed yet in latest JDK12 release (possible regression).

2019-02-28 Thread Norman Maurer
Hi all, I think I found a possible regression / bug in the latest JDK12 release when trying to upgrade the Netty CI server to test with the latest JDK12 release. The problem is that SSLEngine.wrap(…) returns NOT_HANDSHAKING even when there are bytes left that should be consumed (the alert itsel

Re: RFR [13] JDK-8219658: Deadlock in sun.security.ssl.SSLSocketImpl

2019-02-28 Thread Xuelei Fan
ping ... On 2/25/2019 10:07 AM, Xuelei Fan wrote: Hi, Please review the following update:    http://cr.openjdk.java.net/~xuelei/8219658/webrev.00/ There could be a deadlock if different threads are used for socket closing and reading. The update is similar to the bug reported proposed fix,

Re: RFR[13] JDK-8219723: javax/net/ssl/compatibility/Compatibility.java failed on some SNI cases

2019-02-28 Thread Jamil Nimeh
This comment doesn't directly apply to this fix, but tests that depend on the certs from Cert.java and have configurable PKIXParameters might also just set setDate to something in the middle of this validity period so you never have to worry about regenerating the certs due to date issues.  Tha

Re: RFR [13] JDK-8219658: Deadlock in sun.security.ssl.SSLSocketImpl

2019-02-28 Thread Jamil Nimeh
Looks good. On 2/28/2019 9:52 AM, Xuelei Fan wrote: ping ... On 2/25/2019 10:07 AM, Xuelei Fan wrote: Hi, Please review the following update:     http://cr.openjdk.java.net/~xuelei/8219658/webrev.00/ There could be a deadlock if different threads are used for socket closing and reading. T

Re: RFR [13] JDK-8215430: Remove the internal package com.sun.net.ssl

2019-02-28 Thread Bradford Wetmore
AbstractDelegateHttpsURLConnection.java --- 74/88/etc. I haven't checked for sure, but IIRC we made setNewClient public from protected and other such changes in order for these classes to use the delegation model and allow calls to both sun/net/www/protocol

Re: RFR[13] JDK-8219723: javax/net/ssl/compatibility/Compatibility.java failed on some SNI cases

2019-02-28 Thread sha . jiang
Hi Jamil, Thanks for your suggestion. Best regards, John Jiang On 2019/3/1 01:54, Jamil Nimeh wrote: This comment doesn't directly apply to this fix, but tests that depend on the certs from Cert.java and have configurable PKIXParameters might also just set setDate to something in the middle of