Re: RFR[13] JDK-8222391: javax/net/ssl/compatibility/Compatibility.java should be more flexible

2019-04-22 Thread Xuelei Fan
Looks good to me. Xuelei On 4/21/2019 8:27 PM, [email protected] wrote: Hi, This fix just makes some improvements for the manual test javax/net/ssl/compatibility/Compatibility.java in the following points: 1. The test cases could be customized. 2. The current testing JDK (namely, the test.

Re: RFR CSR for 8200400 Restrict Sasl mechanisms

2019-04-22 Thread Sean Mullan
Hi Max, I would like to also review it but may need a couple more days as I'm catching up after being on vacation. Do you also have a webrev of the implementation? I would like to see how the check is implemented. Thanks, Sean On 4/17/19 10:19 PM, Weijun Wang wrote: Pinga again for JDK 13.

Re: RFR CSR for 8200400 Restrict Sasl mechanisms

2019-04-22 Thread Weijun Wang
https://cr.openjdk.java.net/~weijun/8200400/webrev.00/ Thanks, Max > On Apr 23, 2019, at 1:19 AM, Sean Mullan wrote: > > Hi Max, > > I would like to also review it but may need a couple more days as I'm > catching up after being on vacation. Do you also have a webrev of the > implementation?

Re: RFR 8215032: Support Kerberos cross-realm referrals (RFC 6806)

2019-04-22 Thread Weijun Wang
Hi Martin, Sorry for the delay. I went through the changes and they are all in the correct place. Next, I'll read the RFC carefully and make sure all behaviors are correct. In the mean time, you can start preparing the CSR. BTW, what kinds of real world KDC have you tested against? Thanks, Max