Please take a review at the CSR at
https://bugs.openjdk.java.net/browse/JDK-8223682
The text is copied from 4.5.2 and 4.5.2.3 of
https://www.w3.org/TR/xmldsig-core/.
One thing I am not sure is that I haven't include the definition of
ECParameters in 4.5.2.3.1 which is quite long. While I ad
On Fri, May 10, 2019 at 02:23:22PM +0800, Weijun Wang wrote:
> I have read some but probably not as strictly as a reviewer. Anyway, let's
> start dealing with them one by one.
>
> The following 2 lists should have the same orders.
>
> https://bugs.openjdk.java.net/issues/?jql=assignee%20%3D%20nw
This looks good to me. One question, more for my curiosity than
anything else: Is the way you loaded the appData array in the test code
done for any specific reason? Or did you just want to make sure you had
printable ASCII that wasn't all just the same character, so it looked
"random-ish"?
Hi Jamil,
Thank you for the review.
On 5/10/2019 9:22 AM, Jamil Nimeh wrote:
This looks good to me. One question, more for my curiosity than
anything else: Is the way you loaded the appData array in the test code
done for any specific reason? Or did you just want to make sure you had
printa
On 5/10/19 5:04 AM, Weijun Wang wrote:
Please take a review at the CSR at
https://bugs.openjdk.java.net/browse/JDK-8223682
Add an "@since 13" to the new constant.
The text is copied from 4.5.2 and 4.5.2.3 of
https://www.w3.org/TR/xmldsig-core/.
One thing I am not sure is that I haven'
Hi Xuelei,
Based on our earlier discussions, I experimented with a few approaches
and updated the changes accordingly:
http://cr.openjdk.java.net/~valeriep/7107615/webrev.02/
Please let me know if you have more comments.
Thanks,
Valerie
On 4/19/2019 3:58 PM, Valerie Peng wrote:
Ok, thanks f
> On May 10, 2019, at 11:55 PM, Nico Williams
> wrote:
>
> On Fri, May 10, 2019 at 02:23:22PM +0800, Weijun Wang wrote:
>> I have read some but probably not as strictly as a reviewer. Anyway, let's
>> start dealing with them one by one.
>>
>> The following 2 lists should have the same order
> On May 11, 2019, at 4:44 AM, Sean Mullan wrote:
>
> On 5/10/19 5:04 AM, Weijun Wang wrote:
>> Please take a review at the CSR at
>>https://bugs.openjdk.java.net/browse/JDK-8223682
>
> Add an "@since 13" to the new constant.
>
>> The text is copied from 4.5.2 and 4.5.2.3 of
>> https://
Hi,
I'd like to propose Webrev.02:
* http://cr.openjdk.java.net/~mbalao/webrevs/8215032/8215032.webrev.02/
Security properties were introduced mirroring System properties. See CSR
[1].
Thanks,
Martin.-
--
[1] - https://bugs.openjdk.java.net/browse/JDK-8223172
208 synchronized (JceSecurity.class) {
229 synchronized(verificationResults) {
I did not get the point to use two locks. Using one lock, either
JceSecurity.class or verificationResults should be fine.
229-232:
I did not get the point of these 4 lines. Could line 231 move between
line 226 a
10 matches
Mail list logo
