Re: RFR 8221719: Jarsigner Fails To Verify Signed By Alias If Alias Given In Wrong Case

2019-06-09 Thread Philipp Kunz
Hi Max, Thanks for removing the unnecessary imports. Before moving the @test comment block above the imports, my Eclipse picked it up as a JavaDoc comment and I could follow the link to JKS by clicking it in the JavaDoc view of Eclipse without any further configuration. Because I did not want to

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2019-06-09 Thread Weijun Wang
Updated webrev at http://cr.openjdk.java.net/~weijun/6722928/webrev.08/ @build-dev guys, I realize I've never included you in this code review. Please take a look. @Valerie, All comments accepted except for one (see below). In fact, I think I found a bug in gss_release_context that it might

Re: RFR 8215032: Support Kerberos cross-realm referrals (RFC 6806)

2019-06-09 Thread Weijun Wang
I made some tiny changes: s/(in advanced)/(in advance)/, change the property names to fixed width, and remove the full URL for JDK-8223172. One thing not sure. I am not a native English speaker, but "security or system properties" looks a little strange to me. I would use "property". You can cl