Re: RFR 8217375: jarsigner breaks old signature with long lines in manifest

Hi Max, Do I understand correctly that your question refers to if (e == null && MF_MAIN_ATTRS.equals(name)) { e = getMainAttsEntry(); } ? If so, because this sticks closest to the previous behavior. According to src/java.base/share/classes/module-info.java, ManifestDig

Re: RFR 8217375: jarsigner breaks old signature with long lines in manifest

> On Jul 3, 2019, at 4:06 PM, Philipp Kunz wrote: > > Hi Max, > > Do I understand correctly that your question refers to > if (e == null && MF_MAIN_ATTRS.equals(name)) { > e = getMainAttsEntry(); > } > ? Yes. > > If so, because this sticks closest to the previou

Re: [13] RFR 8226963: More clarification on possible sequencing error in GSSContext::unwrap

Looks fine. --Sean On 6/28/19 8:13 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8226963/webrev.00/ Looks like some users are not aware of the MessageProp parameter in unwrap and forget to check about it. This fix adds some code in the example of the

Re: [13] RFR 8227061: KDC.java test behaves incorrectly when AS-REQ contains a PAData not PA-ENC-TS-ENC

Looks fine to me. --Sean On 7/1/19 10:58 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8227061/webrev.00/ The test now iterates through all incoming PA-DATA and find out PA-ENC-TS-ENC. noteg-self. Thanks, Max