Re: RFR[13] JDK-8225745: NoSuchAlgorithmException exception for SHA256withECDSA with RSASSA-PSS support

2019-07-10 Thread Weijun Wang
The change looks fine to me. Thanks, Max > On Jul 10, 2019, at 12:12 PM, Valerie Peng wrote: > > http://cr.openjdk.java.net/~valeriep/8225745/webrev.02/

RFR 8227530: Session Resumption without Server-Side State off by default

2019-07-10 Thread Anthony Scarpino
Hi Can I have a CSR review of this very simple change to turn stateless session resumption off by default https://bugs.openjdk.java.net/browse/JDK-8227530 Tony

Re: RFR 8227530: Session Resumption without Server-Side State off by default

2019-07-10 Thread Xuelei Fan
I may move the content under the "Specification" section to the "Solution" section, as it is about the implementation details. Not a big concern of mine. You can leave it as-is. I added myself as the reviewer. Thanks, Xuelei On 7/10/2019 7:57 AM, Anthony Scarpino wrote: Hi Can I have a CS

Re: RFR [14] JDK-8226374 Restrict signature algorithms and named groups

2019-07-10 Thread Sean Mullan
I think we should modify the description of the jdk.tls.disabledAlgorithms property to state that named groups can also be restricted. For example: diff -r a7b9d6d4940e src/java.base/share/conf/security/java.security --- a/src/java.base/share/conf/security/java.security Thu Jun 20 09:35:41 2

Re: RFR 8227530: Session Resumption without Server-Side State off by default

2019-07-10 Thread Anthony Scarpino
Given the section descriptions say the Solution is an overview and the Specification is code, I'd prefer to leave it as is. If you can set yourself as review, I will propose it. thanks Tony On 7/10/19 8:18 AM, Xuelei Fan wrote: I may move the content under the "Specification" section to the

Re: RFR 8227530: Session Resumption without Server-Side State off by default

2019-07-10 Thread Sean Mullan
Tony, I think we should leave stateless on for JDK 14 (or the main JDK repo) since that way we will continue to get more testing on it. If you push this to 13, it will be automatically pushed to JDK 14 which would change that default. Check with the gatekeeper to make an exception for this so