[13] RFR 8227595: keytool/fakegen/DefaultSignatureAlgorithm.java fails due to "exitValue = 6"

2019-07-16 Thread Weijun Wang
JBS: https://bugs.openjdk.java.net/browse/JDK-8227595 The test cannot use the included fake keypair generator because on Solaris the SunPKCS11-Solaris is more preferred. Like what I have done [1] for the PSS.java test nearby, exclude the test f

Re: RFR 8227437: S4U2proxy cannot continue because server's TGT cannot be found

2019-07-16 Thread Martin Balao
Hi Max, Thanks for your feedback. Here we have webrev.01: http://cr.openjdk.java.net/~mbalao/webrevs/8227437/8227437.webrev.01/ I've done the following changes: * Extended ReferralsTest to test credentials delegation (through CredentialsUtil::acquireS4U2proxyCreds) * See this change in Refer

RFR[13]: 8227551 Session Resumption without Server-Side State off by default

2019-07-16 Thread Anthony Scarpino
Please review the change to set stateless session resumption off default http://cr.openjdk.java.net/~ascarpino/8227551/webrev/ Thanks Tony

Re: RFR 8227437: S4U2proxy cannot continue because server's TGT cannot be found

2019-07-16 Thread Weijun Wang
Krb5Context.java and Krb5LoginModule.java: There is no need to set the aliases, already done inside Krb5Util.credsToTicket(serviceCreds). The case in Krb5LoginModule.java is more complicated, due to your change in webrev.01. See below. > > * Fixed a bug in referral TGTs Credentials (no server

Re: RFR[13]: 8227551 Session Resumption without Server-Side State off by default

2019-07-16 Thread sha . jiang
Hi Tony, Just a minor comment.  242 if (st.compareToIgnoreCase("true") == 0) {  243 statelessSession = true;  244 } Could it simply use the below statement? statelessSession = st.equalsIgnoreCase("true"); Best regards, John Jiang On 2019/7/17 11:12, Antho

Re: RFR 8227437: S4U2proxy cannot continue because server's TGT cannot be found

2019-07-16 Thread Martin Balao
Hi Max, Webrev.02 is ready: http://cr.openjdk.java.net/~mbalao/webrevs/8227437/8227437.webrev.02/ On 7/17/19 12:23 AM, Weijun Wang wrote: > Krb5Context.java and Krb5LoginModule.java: > > There is no need to set the aliases, already done inside > Krb5Util.credsToTicket(serviceCreds). The case in