Re:(JDK-8230297) Slow LoginContext.login() due to repeated ServiceLoader lookups

2019-08-28 Thread Seán Coffey
Thanks Florent. Now visible at https://bugs.openjdk.java.net/browse/JDK-8230297 regards, Sean. On 27/08/2019 20:04, Florent Guillaume wrote: I'm not an Author so I created the ticket on bugreport.java.com , it has the internal review ID 9062061 Thanks, Florent On

Re: [14] RFR 8162628: Migrate cacerts keystore from JKS

2019-08-28 Thread Sean Mullan
On 8/27/19 9:18 AM, Weijun Wang wrote: Oops, sorry. I was calling "new X509CertImp" in PEM keystore and this has not made use of the cache in X509Factory, and since my benchmark test loads keystores hundreds of times it's certainly much slower than JKS. I've disabled the cache and now PEM is o

Re: JDK 14 RFR of JDK-8229999 : Apply java.io.Serial annotations to security types in java.base

2019-08-28 Thread Roger Riggs
Hi Joe, Looks fine to me. Roger On 8/27/19 8:16 PM, Joe Darcy wrote: Hello, Recent work for JDK-8202385: "Annotation to mark serial-related fields and methods" added the java.io.Serial annotation type to the platform. The intention of this new annotation type is to allow serialization-rel

Re: [8u] RFR: 8218780: Update MUSCLE PCSC-Lite header files

2019-08-28 Thread Andrew John Hughes
On 26/08/2019 14:23, Severin Gehwolf wrote: > Hi, > > Could I please get a review of this MUSCLE header files update in > OpenJDK 8u? I'd like to backport this bug as it's also going to be in > Oracle JDK 8u231 (equiv to OpenJDK 8u232) as well. The OpenJDK 11 patch > applies almost cleanly post pa

Re: [14] RFR 8162628: Migrate cacerts keystore from JKS

2019-08-28 Thread Weijun Wang
> On Aug 28, 2019, at 11:00 PM, Sean Mullan wrote: > > On 8/27/19 9:18 AM, Weijun Wang wrote: >> Oops, sorry. I was calling "new X509CertImp" in PEM keystore and this has >> not made use of the cache in X509Factory, and since my benchmark test loads >> keystores hundreds of times it's certai