CSR review request JDK-8233621, Mismatch in jsse.enableMFLNExtension property name

2019-11-05 Thread Xuelei Fan
Hi, May I have the CSR reviewed? https://bugs.openjdk.java.net/browse/JDK-8233652 The system property, "jsse.enableMFLNExtension", was introduced in JDK 9 (See JSSE Reference Guides). However, the implementation code uses "jsse.enableMFLExtension" (without 'N') instead. As the system prop

Re: CSR review request JDK-8233621, Mismatch in jsse.enableMFLNExtension property name

2019-11-05 Thread Anthony Scarpino
I understand the desire to change this, but are we sure the doc should be changed instead of the property? I would tend to believe users code to the doc and don’t notice it wasn’t working. Not reading the source code and code to that implemented name. Otherwise I’d assume someone would have

Re: RFR [14] 8223940: Private key not supported by chosen signature algorithm

2019-11-05 Thread Valerie Peng
Hi Xuelei, Updated webrev looks good. If we have a failing test to verify the changes, perhaps you can try disabling the CKM_RSA_PKCS_PSS in the PKCS11 provider configuration file. Or, you can always comment out the PSS Signature entry registration in SunPKCS11 provider. Thanks, Valerie On

Re: CSR review request JDK-8233621, Mismatch in jsse.enableMFLNExtension property name

2019-11-05 Thread Xuelei Fan
I understand your points. Between using the doc name and the code name, I think using the code name is a little bit safer if someone really use the impl name. However, just a little bit. I’m open to use the doc name if we could get an agreement. Xuelei > On Nov 5, 2019, at 4:32 PM, Antho