RFR[14] JDK-8235813: System property fullCipherSuites is not used by javax/net/ssl/compatibility/Compatibility.java

2019-12-15 Thread sha . jiang
Hi, javax/net/ssl/compatibility/Compatibility.java should use property fullCipherSuites to indicate if testing all of specific cipher suites. In addition, the cases on TLS_ECDH_RSA cipher suites fail due to a RSA-signed EC key certificate has something wrong. Issue: https://bugs.openjdk.java.n

Re: RFR: JDK-8235903: GCC default -fno-common exposes "multiple definition" link errors

2019-12-15 Thread Martin Buchholz
forwarded to other teams for review. On Fri, Dec 13, 2019 at 3:14 AM Patrick Zhang OS < patr...@os.amperecomputing.com> wrote: > Hi > > Please review this patch, if it should be reviewed by any group other than > core-libs, please help forward it. Thanks. > > JBS: https://bugs.openjdk.java.net/br

Re: RFR[14] JDK-8235813: System property fullCipherSuites is not used by javax/net/ssl/compatibility/Compatibility.java

2019-12-15 Thread Xuelei Fan
I think the property is for test code only, is it? The update looks fine to me. Xuelei > On Dec 15, 2019, at 6:09 PM, sha.ji...@oracle.com wrote: > > Hi, > javax/net/ssl/compatibility/Compatibility.java should use property > fullCipherSuites to indicate if testing all of specific cipher suite

Re: RFR[14] JDK-8235813: System property fullCipherSuites is not used by javax/net/ssl/compatibility/Compatibility.java

2019-12-15 Thread sha . jiang
Hi Xuelei, On 2019/12/16 11:22, Xuelei Fan wrote: I think the property is for test code only, is it? Yes. It is only used by this test. The update looks fine to me. Thanks! Best regards, John Jiang Xuelei On Dec 15, 2019, at 6:09 PM, sha.ji...@oracle.com wrote: Hi, javax/net/ssl/compa