RE: RFR: 8237962: give better error output for invalid OCSP response intervals in CertPathValidator checks

2020-02-04 Thread Baesken, Matthias
Sean, Christoph, thanks for the reviews ! > > Looks good. > > --Sean >

RFR 8237804: sun/security/mscapi tests fail with "Key pair not generated, alias already exists"

2020-02-04 Thread Weijun Wang
Please take a review at http://cr.openjdk.java.net/~weijun/8237804/webrev.00/ It's probably that another test run has not cleaned up the entry. Thanks, Max

Re: RFR 8237804: sun/security/mscapi tests fail with "Key pair not generated, alias already exists"

2020-02-04 Thread Sean Mullan
Looks good. --Sean On 2/4/20 7:56 AM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8237804/webrev.00/ It's probably that another test run has not cleaned up the entry. Thanks, Max

RFR(jdk): 8238502: sunmscapi.dll causing EXCEPTION_ACCESS_VIOLATION

2020-02-04 Thread Bradford Wetmore
Simple review request. Weijun has provided the fix, so pushing for him. 8238502: sunmscapi.dll causing EXCEPTION_ACCESS_VIOLATION Reviewed-by: wetmore, coffeys A JNI call isn't properly sizing its arguments, and is causing VM crashes. Brad

RFR(jdk): 8238502: sunmscapi.dll causing EXCEPTION_ACCESS_VIOLATION

2020-02-04 Thread Bradford Wetmore
(Sigh, forgot location) Simple review request. Weijun has provided the fix, so pushing for him. 8238502: sunmscapi.dll causing EXCEPTION_ACCESS_VIOLATION Reviewed-by: wetmore, coffeys A JNI call isn't properly sizing its arguments, and is causing VM crashes. http://cr.openjdk.java.net/~wetmo

Re: RFR(jdk): 8238502: sunmscapi.dll causing EXCEPTION_ACCESS_VIOLATION

2020-02-04 Thread Sean Mullan
Looks good. I assume this should be a Bug and not an Enhancement though? --Sean On 2/4/20 2:42 PM, Bradford Wetmore wrote: (Sigh, forgot location) Simple review request.  Weijun has provided the fix, so pushing for him. 8238502: sunmscapi.dll causing EXCEPTION_ACCESS_VIOLATION Reviewed-by: w

Re: RFR(jdk): 8238502: sunmscapi.dll causing EXCEPTION_ACCESS_VIOLATION

2020-02-04 Thread Bradford Wetmore
Ah yes, defaulted to enhancement. Thanks. Brad On 2/4/2020 11:48 AM, Sean Mullan wrote: Looks good. I assume this should be a Bug and not an Enhancement though? --Sean On 2/4/20 2:42 PM, Bradford Wetmore wrote: (Sigh, forgot location) Simple review request.  Weijun has provided the fix,

Re: RFR(jdk): 8238502: sunmscapi.dll causing EXCEPTION_ACCESS_VIOLATION

2020-02-04 Thread Seán Coffey
Looks fine to me also. Thanks for handling. Sean. On 4 February 2020 21:11:04 GMT, Bradford Wetmore wrote: >Ah yes, defaulted to enhancement. Thanks. > >Brad > > >On 2/4/2020 11:48 AM, Sean Mullan wrote: >> Looks good. I assume this should be a Bug and not an Enhancement >though? >> >> --Sean

RFR[8u252] - MR3 - ALPN & RSASSA-PSS in Java SE 8

2020-02-04 Thread Bradford Wetmore
I added a simple PSS 32-bit windows crash fix, which was previously reviewed in security-dev earlier today [0]. 8238502: sunmscapi.dll causing EXCEPTION_ACCESS_VIOLATION The PSS webrev is now at version .01. Otherwise, everything is identical from last week's request below. The ALPN rema

Re: RFR[8u252] - MR3 - ALPN & RSASSA-PSS in Java SE 8

2020-02-04 Thread Weijun Wang
I reviewed the windows/ changes. Looks fine except there is no need to update PRNG.java. Thanks, Max > On Feb 5, 2020, at 7:24 AM, Bradford Wetmore > wrote: > > 2. RSASSA-PSS: > http://cr.openjdk.java.net/~wetmore/MR3-codereview-8u252/PSS