Re: [15] RFR: 8191395: policy.allowSystemProperty and policy.expandProperties also apply to JAAS configurations

2020-02-06 Thread Sean Mullan
On 2/5/20 8:53 PM, Weijun Wang wrote: sun/security/provider/ConfigFile.java: private boolean expandProp = true; ... String expand = Security.getProperty("policy.expandProperties"); if (expand == null) { expand = System.getProperty("policy.expandProperties"); } i

Re: [15] RFR 8236512: PKCS11 Connection closed after Cipher.doFinal and NoPadding

2020-02-06 Thread Valerie Peng
Ping~ Submitter confirmed that the current webrev addresses the issue. Thanks, Valerie On 1/24/2020 2:01 PM, Valerie Peng wrote: Hi, Can someone help reviewing this? This can only be reproduced with 3rd party HSM vendor, so there is no new regression test. To address this, I removed the ki

[15] RFR 8238448: RSASSA-PSS signature verification fail when using certain odd key sizes

2020-02-06 Thread Valerie Peng
Anyone can help reviewing this? There is a bug in RSASSA-PSS signature verification when the key size is multiples of 8 plus 1 bit. The verification on the encoded message is off by one and verification failed unexpectedly. I added a check and adjusted the starting index for the verification.

Re: [15] RFR 8238448: RSASSA-PSS signature verification fail when using certain odd key sizes

2020-02-06 Thread Xuelei Fan
On 2/6/2020 7:02 PM, Valerie Peng wrote: Anyone can help reviewing this? There is a bug in RSASSA-PSS signature verification when the key size is multiples of 8 plus 1 bit. The verification on the encoded message is off by one and verification failed unexpectedly. I added a check and adjusted

Re: [15] RFR 8236512: PKCS11 Connection closed after Cipher.doFinal and NoPadding

2020-02-06 Thread Xuelei Fan
Hi Valerie, The overall update looks straightforward to me. But I'm not sure the update that why you want to ignore cancel operation exception for verification/decryption? Thanks, Xuelei On 2/6/2020 3:13 PM, Valerie Peng wrote: Ping~ Submitter confirmed that the current webrev addresses t