Re: RFR 8160818: GssKrb5Client violates RFC 4752

2020-02-14 Thread Weijun Wang
Webrev updated at https://cr.openjdk.java.net/~weijun/8160818/webrev.01 > On Feb 14, 2020, at 2:13 PM, Xuelei Fan wrote: > > On 2/13/2020 8:41 PM, Weijun Wang wrote: >> It cannot be final because it was modified later on line 149. >> > I think line 149 is in the same constructor, so it is po

Re: RFR 8160818: GssKrb5Client violates RFC 4752

2020-02-14 Thread Michael Osipov
Am 2020-02-14 um 10:58 schrieb Weijun Wang: Webrev updated at https://cr.openjdk.java.net/~weijun/8160818/webrev.01 This changes looks fine to me according to the RFC. Can this be backported to Java 8? Seems like a no-brainer. Michael

Re: LDAP Channel Binding

2020-02-14 Thread Weijun Wang
> On Jan 22, 2020, at 6:31 AM, Michael Osipov <1983-01...@gmx.net> wrote: > > Am 2020-01-21 um 17:57 schrieb Bernd Eckenfels: >> Hello, >> >> I have now repeated the tests with LdapEnforceChannelBinding=2 and I >> could see the rejection with error code 80090346 for GSSAPI and >> DIGEST-MD5 wi

Re: RFR 8160818: GssKrb5Client violates RFC 4752

2020-02-14 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 2/14/2020 1:58 AM, Weijun Wang wrote: Webrev updated at https://cr.openjdk.java.net/~weijun/8160818/webrev.01 On Feb 14, 2020, at 2:13 PM, Xuelei Fan wrote: On 2/13/2020 8:41 PM, Weijun Wang wrote: It cannot be final because it was modified later on

RFR: 8225128: Add exception for expiring DocuSign root to VerifyCACerts test

2020-02-14 Thread Rajan Halade
May I request you to review this small update to add keynectisrootca to expiry check exempt list. JDK-8225068 will remove this certificate after expiry. diff -r af8e77a59bd8 test/jdk/sun/security/lib/cacerts/VerifyCACerts.java --- a/test/jdk/sun/security/lib/cacerts/VerifyCACerts.java Fri Fe