On 24/02/2020 16:32, Kumar Srinivasan wrote:
Hi Alexey,
Thanks for the update. I glossed over the changes.
Observation: I don’t see a regression test in your webrev, is this
still a work in progress ?
I am very surprised, how a simple socket feature such as this, escape
the JSN-test dragnet
Hi Alan,
It seems this issue could be related to jtreg test
jdk/sun/security/ssl/SSLSocketImpl/ClientTimeout.java
This test passed on JDK8 but fails on JDK11. The test was disabled by
JDK-8196584 ( TLS 1.3 Implementation )
With patch provided this test works better but still fails. I’m trying to
Hi Alexey,
Good catch, this kinda answers my question wrt. "Escape from Alcatraz” comment.
I vaguely remembered some discussions around this in the Mantis/Tiger era in
the Deployment team.
https://bugs.openjdk.java.net/browse/JDK-4836493
The reason I was asking for a regression test, are all t
> JDK11 webrev: http://cr.openjdk.java.net/~yan/8239788/webrev.0/
Maybe, the getSession() could throw InterruptedIOException as well.
I may try to catch the InterruptedIOException, rather than handle it in
the IOException catching block.
Thanks,
Xuelei
On 2/24/2020 11:04 AM, Alexey Bakhtin wr
Hi
I need a code review for the EdDSA support in JEP 339. The code builds
on the existing java implemented constant time classes used for XDH and
the NIST curves. The change also adds classes to the public API to
support EdDSA operations.
All information about the JEP is located at:
JEP 33
sun/security/tools/keytool/ExtOptionCamelCase.java
This is not a compile-only test, but due to the missed @run tag, test is
not run.
Please review the patch to fix this issue.
The patch also fixed @modules. Test performs deep reflection
setAccessible(true) on a non-public member, `open` adde
Thanks Amy for the fix!
Any reason for using othervm to run this test? Otherwise your fix looks good to
me.
Thanks,
Rajan
> On Feb 25, 2020, at 6:48 PM, Amy Lu wrote:
>
> sun/security/tools/keytool/ExtOptionCamelCase.java
>
> This is not a compile-only test, but due to the missed @run tag,
Removed othervm:
http://cr.openjdk.java.net/~amlu/8239979/webrev.01/index.html
Thanks,
Amy
On 2/26/20 11:02 AM, Rajan Halade wrote:
Thanks Amy for the fix!
Any reason for using othervm to run this test? Otherwise your fix
looks good to me.
Thanks,
Rajan
On Feb 25, 2020, at 6:48 PM, Amy Lu
