Re: RFR JDK-8206925,,Support the certificate_authorities extension

On 5/15/20 1:22 AM, Xuelei Fan wrote: Alexey has some good point about the size limit of the extension.  I added more comments about the compatibility impact and interop impact when there is too much CAs to meet the size limits in CSR, source code and release notes. New webrev: https://bugs.o

RFR[15] JDK-8245005: javax/net/ssl/compatibility/BasicConnectTest.java failed with No enum constant

Hi, Possibly run the manual test javax/net/ssl/compatibility/BasicConnectTest.java with JDK builds supporting TLS_KRB5 cipher suites. However these cipher suites are not in test/jdk/javax/net/ssl/TLSCommon/ChpherSuite.java. When convert a TLS_KRB5 cipher suite name to a ChpherSuite enum, Illega

Re: RFR[15] JDK-8245005: javax/net/ssl/compatibility/BasicConnectTest.java failed with No enum constant

Looks good to me. Xuelei On 5/15/2020 5:38 AM, sha.ji...@oracle.com wrote: Hi, Possibly run the manual test javax/net/ssl/compatibility/BasicConnectTest.java with JDK builds supporting TLS_KRB5 cipher suites. However these cipher suites are not in test/jdk/javax/net/ssl/TLSCommon/ChpherSuite.

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

Hi Max, I have updated the webrev (http://cr.openjdk.java.net/~valeriep/8242151/webrev.05/) to address your suggestion below. Touched classes are NamedCurve, CurveDB, ConstraintsParameters, and SunEC. The result of using the single method looks pretty good - clean and shorter code. :) Curv

Re: RFR JDK-8206925,,Support the certificate_authorities extension

New webrev: http://cr.openjdk.java.net/~xuelei/8206925/webrev.04/ On 5/15/2020 5:27 AM, Sean Mullan wrote: On 5/15/20 1:22 AM, Xuelei Fan wrote: Alexey has some good point about the size limit of the extension.  I added more comments about the compatibility impact and interop impact when there

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

Well done. Everything looks fine to me. --Max > On May 16, 2020, at 5:47 AM, Valerie Peng wrote: > > Hi Max, > > I have updated the webrev > (http://cr.openjdk.java.net/~valeriep/8242151/webrev.05/) to address your > suggestion below. Touched classes are NamedCurve, CurveDB, > ConstraintsPa

RFR[15] JDK-8245134: test/lib/jdk/test/lib/security/KeyStoreUtils.java should allow to specify aliases

Hi, This patch adds some new createTrustStore() and createKeyStore() methods to test lib class jdk.test.lib.security.KeyStoreUtils. These new methods allow to pass trust/key store aliases in. Issue: https://bugs.openjdk.java.net/browse/JDK-8245134 Webrev: http://cr.openjdk.java.net/~jjiang/8245