>List.of(KnownOIDs.values()).forEach(o -> {
>register(o);
>});
I wonder if this 'forEach' is better than plain old 'for' in some ways?
```
for (KnownOIDs oid : KnownOIDs.values()) {
register(oid);
}
```
I think a variant with plain 'for' generates a bit less garbage.
Andrey Turbanov
As the the Delegate class takes care of the Cloneable SPI
implementation, it should be sufficient to use "md instanceof Cloneable"
only. It is not a expected behavior that a provider implements
Cloneable but does not really support it.
Xuelei
On 6/5/2020 10:54 PM, Weijun Wang wrote:
Is it p
Hello Max, Daniel,
Thank you for review.
Please review new version of the patch :
http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v5/
In this version:
- TlsChannelBinding class is moved into the com.sun.jndi.ldap.sasl package
- SSL Ceritificate related code is moved from LdapClient into the
Some comments:
1. I just noticed your 2 new files are using the plain GPU license, it should
be GPL + Classpath. Read another source file for an example.
2. Please add some comments in InitialToken.java on what happens to the default
type.
3. I still think "com.sun.security.sasl.tlschannelbind
