Re: Request for review of JDK-8251548

2020-09-17 Thread David Holmes
Hi Sergey, Since OpenJDK has moved to git/github, this needs to reformulated as a Pull Request (PR). Cheers, David On 17/09/2020 5:19 pm, Сергей Цыпанов wrote: Hello, is it possible to have a code review for the changes proposed in JDK-8251548? Sean Mullan has created an issue and web-revi

Request for review of JDK-8251548

2020-09-17 Thread Сергей Цыпанов
Hello, is it possible to have a code review for the changes proposed in JDK-8251548? Sean Mullan has created an issue and web-review and can sponsor the patch as soos as it gets properly reviewed. As Doug Lea claims in http://cs.oswego.edu/pipermail/concurrency-interest/2015-December/014770.htm

Re: Request for review of JDK-8251548

2020-09-17 Thread Сергей Цыпанов
Hi David, thanks for pointing this out! I've created a PR there [1], but GitHub for some reason wants me to sign OCA, which I have already signed in 2017. I've redone the procedure and now I'm waiting for verification. Regards, Sergey 1. https://github.com/openjdk/jdk/pull/218 17.09.2020, 09:

Re: Request for review of JDK-8251548

2020-09-17 Thread David Holmes
On 17/09/2020 7:24 pm, Сергей Цыпанов wrote: Hi David, thanks for pointing this out! I've created a PR there [1], but GitHub for some reason wants me to sign OCA, which I have already signed in 2017. I've redone the procedure and now I'm waiting for verification. Did you not follow these ins

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic

2020-09-17 Thread Ard Biesheuvel
On Thu, 17 Sep 2020 05:18:28 GMT, Fei Yang wrote: >> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com >> >> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions. >> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto >> Extensions: >> https:

Re: SSLSocket HandshakeCompletionListener Threading

2020-09-17 Thread Xuelei Fan
I thought more about the problem. I could see the performance improvement requirements for heavy loaded system. But it may not worthy of a complicated proposal, as the Loom feature could mitigate the impact. Maybe, a new system property could be defined, for example, "jdk.tls.server/client.h

RFR: 8251548 Remove unnecessary explicit initialization of volatile variables in security-libs code

2020-09-17 Thread Сергей Цыпанов
Hello, is it possible to have a code review for the changes proposed in JDK-8251548 (originally contributed via https://mail.openjdk.java.net/pipermail/security-dev/2020-June/022137.html)? Sean Mullan has created an issue and web-review and can sponsor the patch as soos as it gets properly revi

RFR: 8249783: Simplify DerValue and DerInputStream

2020-09-17 Thread Weijun Wang
This code change rewrites DerValue into a mostly immutable class and simplifies DerInputStream as a wrapper for a series of DerValues objects. DerInputBuffer is removed. All existing methods of DerValue and DerInputStream should still work with the exact same behavior, except for a few places wh

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-17 Thread Stuart Marks
On Fri, 11 Sep 2020 15:17:58 GMT, Bradford Wetmore wrote: >> Ok, sorry for the distraction. > > Our local Santuario maintainer says: > > In general, changes to Apache Santuario should also be made at Apache so we > stay in sync. Hi @doom369, I hope we didn't end up wasting too much of your tim