On Sat, 10 Oct 2020 13:15:51 GMT, Kevin Rushforth wrote:
>> I see Linux x64 failed. However, I don't seem to be able to withdraw my
>> patch approval.
>> However, please consider it withdrawn.
>
> @theRealAph if you still need to, you can withdraw your approval by reviewing
> it again and selec
> This patch contains the changes associated with the third incubation round of
> the foreign memory access API incubation
> (see JEP 393 [1]). This iteration focus on improving the usability of the API
> in 3 main ways:
> * first, by providing a way to obtain truly *shared* segments, which can b
> ### Summary
>
> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
> which can lead to the `ZipException "invalid
> entry compressed size"`.
> ### Motivation
>
> In general it is not safe to directly write a ZipEntry obtained from
> `ZipInputStream.getNextEntry()`,
> `Zi
On Mon, 12 Oct 2020 10:50:48 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the third incubation round
>> of the foreign memory access API incubation
>> (see JEP 393 [1]). This iteration focus on improving the usability of the
>> API in 3 main ways:
>> * fir
On Sun, 11 Oct 2020 22:14:18 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 189:
>>
>>> 187: * {@code ZipEntry.DEFLATED}) entries when {@link
>>> ZipEntry#setCompressedSize(long)}
>>> 188: * has not been explicitly called on the {@cod
On Mon, 12 Oct 2020 11:44:28 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Mon, 12 Oct 2020 11:44:28 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On 12/10/2020 12:49, Volker Simonis wrote:
:
Did you had a chance to look at the CSR? I think somebody has to review it before I can
move it to "Finalized".
The updated javadoc looks good. Once Lance has seen it then I think the
CSR would be updated so that it's in sync with the proposal and t
On Fri, 9 Oct 2020 13:22:08 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8229867: Re-examine synchronization usages in http and https protocol
>> handlers
>>
>> Incorporated review feedba
> Hi,
>
> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use
> virtual-thread friendly locking instead of
> synchronized monitors.
> Most of the changes are mechanical - but there are still a numbers of subtle
> non-mechanical differences that are
> outlined below:
> 1. src/j
On Mon, 12 Oct 2020 13:50:30 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use
>> virtual-thread friendly locking instead of
>> synchronized monitors.
>> Most of the changes are mechanical - but there are still a numbers of subtle
>> n
> Contributed-by: [email protected], [email protected]
>
> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions.
> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto
> Extensions:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
On Mon, 12 Oct 2020 12:48:36 GMT, Alan Bateman wrote:
>> Volker Simonis has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR. The
>> pull request contains one new com
On Mon, 12 Oct 2020 11:44:28 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Mon, 12 Oct 2020 11:44:28 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Mon, 12 Oct 2020 15:35:12 GMT, Lance Andersen wrote:
>> Volker Simonis has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR. The
>> pull request contains one new c
On Mon, 12 Oct 2020 15:49:29 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/util/jar/JarOutputStream.java line 81:
>>
>>> 79: * any previous entry. The default compression method will be
>>> 80: * used if no compression method was specified for the entry.
>>> 81: * W
On Thu, 8 Oct 2020 23:15:36 GMT, Valerie Peng wrote:
> Could someone help reviewing this one-line change? This changes the provider
> list used during jar verification from
> InheritableThreadLocal to ThreadLocal. Existing usage and handling uses this
> field as temporary thread-specific
> prov
On Thu, 8 Oct 2020 06:51:08 GMT, Anthony Scarpino wrote:
>> 8253821: Improve ByteBuffer performance with GCM
>
> Anthony Scarpino has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Xuelei comments
src/java.base/share/classes/com/sun/crypto/pr
> This patch contains the changes associated with the third incubation round of
> the foreign memory access API incubation
> (see JEP 393 [1]). This iteration focus on improving the usability of the API
> in 3 main ways:
> * first, by providing a way to obtain truly *shared* segments, which can b
On Mon, 12 Oct 2020 11:42:04 GMT, Magnus Ihse Bursie wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tweak referenced to MemoryAddressProxy in Utils.java
>
> Build changes look good.
I've just uploaded a bi
On Thu, 8 Oct 2020 06:51:08 GMT, Anthony Scarpino wrote:
>> 8253821: Improve ByteBuffer performance with GCM
>
> Anthony Scarpino has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Xuelei comments
src/java.base/share/classes/com/sun/crypto/pr
> This patch contains the changes associated with the third incubation round of
> the foreign memory access API incubation
> (see JEP 393 [1]). This iteration focus on improving the usability of the API
> in 3 main ways:
> * first, by providing a way to obtain truly *shared* segments, which can b
On Thu, 8 Oct 2020 01:22:09 GMT, Anthony Scarpino wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java line 744:
>>
>>> 742: } else {
>>> 743: return core.doFinal(input, output);
>>> 744: }
>>
>> It seems this block is
> Could someone please help review this RFE? Update existing RSA key pair
> generation code following the guidelines from
> FIPS 186-4 and FIPS 186-5 (draft). Current proposed changes updates the prime
> generation code (for P, Q) based on FIPS
> 186-4 B.3.3 when keysize and public exponent met t
On Mon, 12 Oct 2020 07:02:05 GMT, Fei Yang wrote:
>
>
> > I have looked at the java security changes, i.e.
> > src/java.base/share/classes/sun/security/provider/SHA3.java. It looks
> > fine.
>
> @valeriepeng : I see you are not listed under "Reviewers" commit message
> part, could you please
26 matches
Mail list logo
