On Thu, 15 Oct 2020 22:39:50 GMT, Coleen Phillimore wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Re-add file erroneously deleted (detected as rename)
>
> src/hotspot/cpu/x86/foreign_globals_x86.cpp line 2
> This patch contains the changes associated with the third incubation round of
> the foreign memory access API incubation
> (see JEP 393 [1]). This iteration focus on improving the usability of the API
> in 3 main ways:
> * first, by providing a way to obtain truly *shared* segments, which can b
On Thu, 15 Oct 2020 22:44:54 GMT, Coleen Phillimore wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Re-add file erroneously deleted (detected as rename)
>
> src/hotspot/cpu/x86/foreign_globals_x86.hpp line 3
On Thu, 15 Oct 2020 22:52:14 GMT, Coleen Phillimore wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Re-add file erroneously deleted (detected as rename)
>
> src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp line
On Thu, 15 Oct 2020 22:42:49 GMT, Coleen Phillimore wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Re-add file erroneously deleted (detected as rename)
>
> src/hotspot/cpu/x86/foreign_globals_x86.cpp line 5
> Major points in CSR at https://bugs.openjdk.java.net/browse/JDK-8245274:
>
> - new sigalg "RSASSA-PSS", "EdDSA", "Ed25519" and "Ed448" can be used in
> jarsigner
>
> - The ".RSA" and ".EC" block extension types (PKCS #7 SignedData inside a
> signed JAR) are reused for new signature
> algori
On Fri, 16 Oct 2020 02:30:55 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/pkcs/PKCS7.java line 818:
>>
>>> 816: DerOutputStream derSigAlg = new DerOutputStream();
>>> 817: sigAlgID.derEncode(derSigAlg);
>>> 818: derAlgs.writeImplicit((by
On Fri, 16 Oct 2020 01:38:44 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/util/SignatureUtil.java line 94:
>>
>>> 92: * @return an AlgorithmParameterSpec object
>>> 93: * @throws ProviderException
>>> 94: */
>>
>> Well, I am a bit unsure about your changes
On Fri, 16 Oct 2020 15:51:25 GMT, Weijun Wang wrote:
>> Major points in CSR at https://bugs.openjdk.java.net/browse/JDK-8245274:
>>
>> - new sigalg "RSASSA-PSS", "EdDSA", "Ed25519" and "Ed448" can be used in
>> jarsigner
>>
>> - The ".RSA" and ".EC" block extension types (PKCS #7 SignedData in
