Re: RFR: 8255299: Drop explicit zeroing at instantiation of Atomic* objects [v2]

2020-10-28 Thread Сергей Цыпанов
> As discussed in https://github.com/openjdk/jdk/pull/510 there is never a > reason to explicitly instantiate any instance of `Atomic*` class with its > default value, i.e. `new AtomicInteger(0)` could be replaced with `new > AtomicInteger()` which is faster: > @State(Scope.Thread) > @OutputTime

Re: RFR: 8255299: Drop explicit zeroing at instantiation of Atomic* objects [v2]

2020-10-28 Thread Сергей Цыпанов
On Sat, 24 Oct 2020 23:12:09 GMT, Phil Race wrote: >> Сергей Цыпанов has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains one additional >> commit si

Re: RFR: 8255299: Drop explicit zeroing at instantiation of Atomic* objects [v2]

2020-10-28 Thread Sergey Bylokhov
On Wed, 28 Oct 2020 08:40:02 GMT, Сергей Цыпанов wrote: >> client changes are fine > > Rebased onto master to have the fix introduced in > https://github.com/openjdk/jdk/pull/778 FYI it is better to use merge, instead of rebase+force push. Rebase breaks history and all existed code comments.

Re: RFR: 8255299: Drop explicit zeroing at instantiation of Atomic* objects [v2]

2020-10-28 Thread Сергей Цыпанов
On Wed, 28 Oct 2020 08:49:38 GMT, Sergey Bylokhov wrote: >> Rebased onto master to have the fix introduced in >> https://github.com/openjdk/jdk/pull/778 > > FYI it is better to use merge, instead of rebase+force push. Rebase breaks > history and all existed code comments. @mrserb thanks for po

Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-10-28 Thread Magnus Ihse Bursie
On Tue, 22 Sep 2020 14:04:55 GMT, Sean Mullan wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove JDKOPT_DETECT_INTREE_EC from configure.ac > > throw new IllegalStateException( > new InvalidA

Integrated: 8255299: Drop explicit zeroing at instantiation of Atomic* objects

2020-10-28 Thread Сергей Цыпанов
On Thu, 22 Oct 2020 20:46:15 GMT, Сергей Цыпанов wrote: > As discussed in https://github.com/openjdk/jdk/pull/510 there is never a > reason to explicitly instantiate any instance of `Atomic*` class with its > default value, i.e. `new AtomicInteger(0)` could be replaced with `new > AtomicInteg

Re: RFR: 8255299: Drop explicit zeroing at instantiation of Atomic* objects [v2]

2020-10-28 Thread Daniel Fuchs
On Wed, 28 Oct 2020 08:56:05 GMT, Сергей Цыпанов wrote: >> FYI it is better to use merge, instead of rebase+force push. Rebase breaks >> history and all existed code comments. > > @mrserb thanks for pointing this out! Thanks for updating with latest master changes Sergey! My tests were all gre

Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-10-28 Thread Anthony Scarpino
On Wed, 28 Oct 2020 10:52:27 GMT, Magnus Ihse Bursie wrote: >> throw new IllegalStateException( >> new InvalidAlgorithmParameterException( >> "Curve not supported: Private: " + >> ((privNC != null) ? privNC.toString() : " unknown") + >>

RFR: 8255536: Remove the directsign property and option

2020-10-28 Thread Weijun Wang
I regret adding the `directsign` property/option to JarSigner/jarsigner. See the bug for details. - Commit messages: - 8255536: Remove the directsign property and option Changes: https://git.openjdk.java.net/jdk/pull/915/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=

RFR: 8255494: PKCS7 should use digest algorithm to verify the signature

2020-10-28 Thread Weijun Wang
This is a regression made by [JDK-8242068](https://bugs.openjdk.java.net/browse/JDK-8242068). When the digest algorithm is not the same as the hash part of the signature algorithm, we used to combine the digest algorithm with the key part of the signature algorithm into a new signature algorith

RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

2020-10-28 Thread Valerie Peng
Could someone please help review this PKCS#11 v3.0 header files update? Changes are straight-forward as below: 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0 2) Updated java side w/ the new constants definitions and name/error code mappings. For the native headers, it's a direct copy of the o

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

2020-10-28 Thread Hai-May Chao
On Wed, 28 Oct 2020 21:35:25 GMT, Valerie Peng wrote: > Could someone please help review this PKCS#11 v3.0 header files update? > > Changes are straight-forward as below: > 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0 > 2) Updated java side w/ the new constants definitions and name/error co

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

2020-10-28 Thread Weijun Wang
On Thu, 29 Oct 2020 02:18:00 GMT, Hai-May Chao wrote: >> Could someone please help review this PKCS#11 v3.0 header files update? >> >> Changes are straight-forward as below: >> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0 >> 2) Updated java side w/ the new constants definitions and name/err

Re: Request for comment: the session ticket protection scheme for distributed TLS sessions.

2020-10-28 Thread Xue-Lei Fan
The PNG may be too large to open from some mail system. Here is the PDF version. BTW, I also made an update on the use of AEAD algorithm with additional data. Thanks, Xuelei distributed_credential_protection.pdf Description: Adobe PDF document > On Oct 23, 2020, at 8:58 AM, Xuelei Fan wr