Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]

On Wed, 25 Nov 2020 14:10:17 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8248862: Implement Enhanced Pseudo-Random Number Generators >> >> Changes to RandomGeneratorFactory requested by @Pau

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v5]

> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at > http://cr.openjdk.java.net/~jlaskey/prng/doc/a

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]

On Wed, 25 Nov 2020 14:16:20 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8248862: Implement Enhanced Pseudo-Random Number Generators >> >> Changes to RandomGeneratorFactory requested by @Pau

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v6]

> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at > http://cr.openjdk.java.net/~jlaskey/prng/doc/a

RFR: 8220730: sun.security.provider.SecureRandom default constructor has wrong documentation

This is to fix some out-of-date information in the javadoc for the SHA1PRNG that has generated a customer bug. - Commit messages: - 8220730: sun.security.provider.SecureRandom default constructor has wrong documentation Changes: https://git.openjdk.java.net/jdk/pull/1461/files We

Re: RFR: 8220730: sun.security.provider.SecureRandom default constructor has wrong documentation [v2]

> This is to fix some out-of-date information in the javadoc for the SHA1PRNG > that has generated a customer bug. Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revision: Minor grammar error - Changes: - all: https://git.

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators

Ok, i've taking the time to read some literature about random generators because for me the Mersenne Twister was still the king. The current API proposed as clearly two levels, you have the user level and the implementation level, at least the implementation level should seen as a SPI RandomGe

Re: RFR: 8220730: sun.security.provider.SecureRandom default constructor has wrong documentation [v2]

On Thu, 26 Nov 2020 16:59:11 GMT, Bradford Wetmore wrote: >> This is to fix some out-of-date information in the javadoc for the SHA1PRNG >> that has generated a customer bug. > > Bradford Wetmore has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8220730: sun.security.provider.SecureRandom default constructor has wrong documentation [v2]

On Thu, 26 Nov 2020 17:55:06 GMT, Bradford Wetmore wrote: >> src/java.base/share/classes/sun/security/provider/SecureRandom.java line 78: >> >>> 76: * >>> 77: * The first time this constructor is called in a given Virtual >>> Machine, >>> 78: * it may take several seconds of CPU

Re: RFR: 8220730: sun.security.provider.SecureRandom default constructor has wrong documentation [v2]

On Thu, 26 Nov 2020 17:41:23 GMT, Weijun Wang wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor grammar error > > src/java.base/share/classes/sun/security/provider/SecureRandom.java line 78: > >> 76:

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v7]

> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at > http://cr.openjdk.java.net/~jlaskey/prng/doc/a

Re: RFR: 8220730: sun.security.provider.SecureRandom default constructor has wrong documentation [v3]

> This is to fix some out-of-date information in the javadoc for the SHA1PRNG > that has generated a customer bug. Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revision: Code review comments - Changes: - all: https://git

Re: RFR: 8220730: sun.security.provider.SecureRandom default constructor has wrong documentation [v3]

On Thu, 26 Nov 2020 18:33:15 GMT, Bradford Wetmore wrote: >> This is to fix some out-of-date information in the javadoc for the SHA1PRNG >> that has generated a customer bug. > > Bradford Wetmore has updated the pull request incrementally with one > additional commit since the last revision: >

Integrated: 8220730: sun.security.provider.SecureRandom default constructor has wrong documentation

On Thu, 26 Nov 2020 16:34:53 GMT, Bradford Wetmore wrote: > This is to fix some out-of-date information in the javadoc for the SHA1PRNG > that has generated a customer bug. This pull request has now been integrated. Changeset: 62d72dec Author:Bradford Wetmore URL: https://git.openjd

Re: RFR: 8220730: sun.security.provider.SecureRandom default constructor has wrong documentation [v2]

On Thu, 26 Nov 2020 17:57:03 GMT, Weijun Wang wrote: >> Are you talking about the line 78? Yes, you are correct, I didn't update >> anything beyond the initial comment. I can update that as well. > > Yes, the paragraph starting from line 77. Got it, thanks for the reviews. - PR: