On Tue, 8 Dec 2020 18:52:05 GMT, Sean Mullan wrote:
>> Marked as reviewed by xuelei (Reviewer).
>
> This will also require a CSR since you are making some specification changes.
> I'm not sure if you were trying to get this into 16, but it is probably too
> late to make JDK 16 since RDP is a co
On Mon, 7 Dec 2020 20:29:56 GMT, Andy Herrick wrote:
> increase retries and timeout increasing in runMsiexecWithRetries
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/1676
Some minor comments:
* General
o I think you can backtick the UnsupportedOperationException text
so it shows up in monospace format.
* Specification
o I think text-wise the wording is fine. IIRC don't we normally
show the proposed changes as a diff? Or is that just one
On Fri, 11 Dec 2020 18:35:27 GMT, Hai-May Chao wrote:
>> This will also require a CSR since you are making some specification
>> changes. I'm not sure if you were trying to get this into 16, but it is
>> probably too late to make JDK 16 since RDP is a couple of days away. You can
>> push to 17
On Fri, 11 Dec 2020 19:43:41 GMT, Hai-May Chao wrote:
>> Please review the CSR (JDK-8258114) at:
>> https://bugs.openjdk.java.net/browse/JDK-8258114
>
> Thanks for the review. Updated CSR to backtick the
> UnsupportedOperationException text. I thought about placing the diff in
> Specification s
No need to change it IMO. I'm fine with it as is.--Jamil
Original message From: Hai-May Chao
Date: 12/11/20 11:45 AM (GMT-08:00) To: security-dev@openjdk.java.net
Subject: Re: RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec
mismatch to its behavior [v2] On Fr
On Fri, 11 Dec 2020 19:59:17 GMT, Xue-Lei Andrew Fan wrote:
>> Thanks for the review. Updated CSR to backtick the
>> UnsupportedOperationException text. I thought about placing the diff in
>> Specification section, but decided to keep the document change in this
>> format which is same as our
The TLS protocols are designed to tolerant unknown TLS extensions. However,
although it is not common, there are a few TLS implementations that cannot
handle unknown extensions properly. As results in unexpected interoperability
issue when new extensions are introduced in JDK. The interoperabili
On Fri, 13 Nov 2020 22:00:26 GMT, Weijun Wang wrote:
>> This is a multi-commits PR that upgrades xmldsig to be equivalent to
>> Santuario 2.2.0.
>>
>> The first step is an auto-import. The JDK implementation is removed first
>> and Santuario code are imported. Some unrelated files (Ex: encrypt
