On Sun, 20 Dec 2020 22:48:24 GMT, Sergey Bylokhov wrote:
>> So these changes are all over the place which means no one person knows how
>> to test all of it.
>> Have you run the sound, swing tests, and the printing tests on unix and
>> windows ?
>> For printing for sure you'll need to do some
> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo
Andrey Turbanov has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains
On Mon, 21 Dec 2020 07:55:06 GMT, Andrey Turbanov
wrote:
>> I already suggested this, but anyway please always extract the changes to
>> the java.desktop module to the separate PR.
>
> I've extracted changes in java.desktop into separate PR #1856
> Reverted this changes from current PR.
Probab
> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo
revert changes in Apache Sant
On Mon, 21 Dec 2020 09:16:11 GMT, Andrey Turbanov
wrote:
>> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8080272: Refactor I/O stream copying
On Mon, 21 Dec 2020 09:40:39 GMT, Сергей Цыпанов
wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo
>> revert changes in Apache Santuari
On Mon, 21 Dec 2020 09:51:25 GMT, Andrey Turbanov
wrote:
>> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 2459:
>>
>>> 2457: byte[] bytes = in.readAllBytes();
>>> 2458: return
>>> CertificateFactory.getInstance("X509").generateCRLs(
>>> 2
On Sat, 19 Dec 2020 05:48:53 GMT, Xue-Lei Andrew Fan wrote:
> It looks like the break is missed in the loop of the
> SSLCipher.createReadCipher() and createWriteCipher() methods. See the change
> set.
>
> Code cleanup, no new regression test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK
> It looks like the break is missed in the loop of the
> SSLCipher.createReadCipher() and createWriteCipher() methods. See the change
> set.
>
> Code cleanup, no new regression test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8258736
Xue-Lei Andrew Fan has updated the pull request incr
On Mon, 21 Dec 2020 18:37:46 GMT, Bradford Wetmore wrote:
> Approved with the condition of updating the copyright year.
>
Good catch!
> There was also a failure in the Linux Presubmit tests which is probably bogus.
>
I checked the failure, which is not related to this update.
> Looks good oth
On Sat, 19 Dec 2020 05:48:53 GMT, Xue-Lei Andrew Fan wrote:
> It looks like the break is missed in the loop of the
> SSLCipher.createReadCipher() and createWriteCipher() methods. See the change
> set.
>
> Code cleanup, no new regression test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK
On Sat, 19 Dec 2020 05:48:53 GMT, Xue-Lei Andrew Fan wrote:
> It looks like the break is missed in the loop of the
> SSLCipher.createReadCipher() and createWriteCipher() methods. See the change
> set.
>
> Code cleanup, no new regression test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK
Comparing to Collection.toArray(new T[size)), he Collection.toArray(new T[0])
seems faster, safer and contractually cleaner. In the update, the use of
Collection.toArray(new T[size)) in the SunJSSE provider implementation is
replaced with Collection.toArray(new T[0]).
Bug: https://bugs.openjdk
13 matches
Mail list logo
