Re: RFR: 8258186: Replace use of JNI_COMMIT mode with mode 0

2020-12-23 Thread Alan Bateman
On Wed, 23 Dec 2020 02:13:38 GMT, Valerie Peng wrote: > Could someone please help review this trivial change - just replace > JNI_COMMIT with 0 for all ReleasePrimitiveArrayCritical calls. > > Thanks, > Valerie Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.jav

Integrated: 8253368: TLS connection always receives close_notify exception

2020-12-23 Thread Sean Coffey
On Fri, 13 Nov 2020 14:16:35 GMT, Sean Coffey wrote: > removing the "closing inbound before receiving peer's close_notify" exception > that can be seen with TLS stack if calling close on inbound. After reading > the relevant parts of the TLS v1.2/v1.3 RFCs, I believe the local end point > does

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v6]

2020-12-23 Thread Andrey Turbanov
On Wed, 2 Dec 2020 05:01:28 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > comments v4 src/java.base/share/classes/com/sun/crypto/provid

RFR: 8258851: Mismatch in SunPKCS11 provider registration properties and actual implementation

2020-12-23 Thread Valerie Peng
Max, can you help taking a look? This trivial change fixes the inconsistent registration properties to match the actual implementation. In addition to the DH->EC KeyFactory inconsistency, the new test finds another MAC->Mac typo. Mach5 run is clean. Thanks, Valerie - Commit message

Re: RFR: 8258186: Replace use of JNI_COMMIT mode with mode 0

2020-12-23 Thread Valerie Peng
On Wed, 23 Dec 2020 11:58:46 GMT, Alan Bateman wrote: >> Could someone please help review this trivial change - just replace >> JNI_COMMIT with 0 for all ReleasePrimitiveArrayCritical calls. >> >> Thanks, >> Valerie > > Marked as reviewed by alanb (Reviewer). Thanks for the review. --

Integrated: 8258186: Replace use of JNI_COMMIT mode with mode 0

2020-12-23 Thread Valerie Peng
On Wed, 23 Dec 2020 02:13:38 GMT, Valerie Peng wrote: > Could someone please help review this trivial change - just replace > JNI_COMMIT with 0 for all ReleasePrimitiveArrayCritical calls. > > Thanks, > Valerie This pull request has now been integrated. Changeset: cd94606c Author:Valerie

Re: RFR: 8258851: Mismatch in SunPKCS11 provider registration properties and actual implementation

2020-12-23 Thread Weijun Wang
On Wed, 23 Dec 2020 19:15:48 GMT, Valerie Peng wrote: > Max, can you help taking a look? This trivial change fixes the inconsistent > registration properties to match the actual implementation. > > In addition to the DH->EC KeyFactory inconsistency, the new test finds > another MAC->Mac typo.

Re: RFR: 8258851: Mismatch in SunPKCS11 provider registration properties and actual implementation

2020-12-23 Thread Valerie Peng
On Wed, 23 Dec 2020 22:35:43 GMT, Weijun Wang wrote: >> Max, can you help taking a look? This trivial change fixes the inconsistent >> registration properties to match the actual implementation. >> >> In addition to the DH->EC KeyFactory inconsistency, the new test finds >> another MAC->Mac ty

Integrated: 8258851: Mismatch in SunPKCS11 provider registration properties and actual implementation

2020-12-23 Thread Valerie Peng
On Wed, 23 Dec 2020 19:15:48 GMT, Valerie Peng wrote: > Max, can you help taking a look? This trivial change fixes the inconsistent > registration properties to match the actual implementation. > > In addition to the DH->EC KeyFactory inconsistency, the new test finds > another MAC->Mac typo.