Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port

2021-01-23 Thread Andrew Haley
On Fri, 22 Jan 2021 18:49:42 GMT, Anton Kozlov wrote: > Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new ca

Re: RFR: 8258915: Temporary buffer cleanup [v3]

2021-01-23 Thread Weijun Wang
On Sat, 23 Jan 2021 03:59:12 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more wrap, less copy > > src/java.base/share/classes/sun/security/pkcs/PKCS8Key.java line 221: > >> 219: if (en

Re: RFR: 8258915: Temporary buffer cleanup [v4]

2021-01-23 Thread Weijun Wang
On Sat, 23 Jan 2021 05:09:46 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> keyfactory operations on own keyspec > > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java line > 1

Re: RFR: 8258915: Temporary buffer cleanup [v4]

2021-01-23 Thread Weijun Wang
On Sat, 23 Jan 2021 16:12:43 GMT, Weijun Wang wrote: >> src/jdk.crypto.ec/share/classes/sun/security/ec/ECPrivateKeyImpl.java line >> 133: >> >>> 131: out.putInteger(1); // version 1 >>> 132: out.putOctetString(sOctets); >>> 133: Arrays.fill(sOctets, (byte)0)