Are you calling the PKCS12Attribute(String, String) constructor from
your code? That API currently specifies that String values are encoded
as UTF-8, so we could not change the behavior without a specification
change. Can you use the PKCS12Attribute(byte[]) constructor instead
which takes a DER
Please review this fix to remove the Validator.VAR_PLUGIN_CODE_SIGNING variant
and related code that is no longer needed in the PKIX implementation.
-
Commit messages:
- 8232066: Remove outdated code/methods from PKIX implementation
Changes: https://git.openjdk.java.net/jdk/pull/49
On Thu, 29 Jul 2021 14:24:52 GMT, Sean Mullan wrote:
> Please review this fix to remove the Validator.VAR_PLUGIN_CODE_SIGNING
> variant and related code that is no longer needed in the PKIX implementation.
Looks good. One nit: `Validator::getInstance` methods are internal. Does it
really matte
Improve the clarity of comments in the ObjectInputFilter FilterInThread example.
-
Commit messages:
- 8271489: (doc) Clarify Filter Factory example
- 8270398: Enhance canonicalization
- 8270404: Better canonicalization
- Merge
- Merge
- 8263531: Remove unused buffer int
- 82627
On Thu, 29 Jul 2021 15:09:14 GMT, Weijun Wang wrote:
> Looks good. One nit: `Validator::getInstance` methods are internal. Does it
> really matter to check for null?
Good point. Also, NPE will be thrown later when an `EndEntityChecker` is
invoked and it needs to determine the variant to use. H
> Please review this fix to remove the Validator.VAR_PLUGIN_CODE_SIGNING
> variant and related code that is no longer needed in the PKIX implementation.
Sean Mullan has updated the pull request incrementally with one additional
commit since the last revision:
Remove NPE check in Validator.get
On Thu, 29 Jul 2021 16:36:21 GMT, Roger Riggs wrote:
> Improve the clarity of comments in the ObjectInputFilter FilterInThread
> example.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk17/pull/292
