Re: RFR: 8272805: Avoid looking up standard charsets [v2]

2021-08-26 Thread Sergey Bylokhov
On Sun, 22 Aug 2021 23:02:06 GMT, Sergey Bylokhov wrote: >> This is the continuation of JDK-8233884, JDK-8271456, and JDK-8272120. >> >> In many places standard charsets are looked up via their names, for example: >> absolutePath.getBytes("UTF-8"); >> >> This could be done more efficiently(up t

Re: RFR: 8272805: Avoid looking up standard charsets [v2]

2021-08-26 Thread Sergei Ustimenko
On Thu, 26 Aug 2021 17:39:36 GMT, Sergey Bylokhov wrote: >> Sergey Bylokhov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 14 additional >> com

Re: RFR: 8272805: Avoid looking up standard charsets [v2]

2021-08-26 Thread Sergey Bylokhov
On Thu, 26 Aug 2021 17:39:36 GMT, Sergey Bylokhov wrote: >> Sergey Bylokhov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 14 additional >> com

RFR: 8262186: Callback semantics of the method X509KeyManager.chooseClientAlias(...)

2021-08-26 Thread Weijun Wang
This code change collects all key types and runs `chooseClientAlias` only once. - Commit messages: - no more reflection in test - 8262186: Callback semantics of the method X509KeyManager.chooseClientAlias(...) Changes: https://git.openjdk.java.net/jdk/pull/5257/files Webrev: http

Integrated: 8272863: Replace usages of Collections.sort with List.sort call in public java modules

2021-08-26 Thread Andrey Turbanov
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov wrote: > Collections.sort is just a wrapper, so it is better to use an instance method > directly. This pull request has now been integrated. Changeset: d732c309 Author:Andrey Turbanov Committer: Sergey Bylokhov URL: https://git.o

RFR: 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code

2021-08-26 Thread Bradford Wetmore
Did a quick sweep of some minor non-standard javadoc issues. This silences 3rd party tooling warnings and fixes some linkage issues. - Commit messages: - 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code Changes: https://git.openjdk.java.net/jdk/pull/5271/

Re: RFR: 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code

2021-08-26 Thread Xue-Lei Andrew Fan
On Fri, 27 Aug 2021 01:35:17 GMT, Bradford Wetmore wrote: > Did a quick sweep of some minor non-standard javadoc issues. This silences > 3rd party tooling warnings and fixes some linkage issues. Looks good to me. Thank you for the clean up. src/java.base/share/classes/javax/net/ssl/SNIHostNa

Re: RFR: 8262186: Callback semantics of the method X509KeyManager.chooseClientAlias(...)

2021-08-26 Thread Xue-Lei Andrew Fan
On Wed, 25 Aug 2021 19:00:06 GMT, Weijun Wang wrote: > This code change collects all key types and runs `chooseClientAlias` only > once. src/java.base/share/classes/sun/security/ssl/X509Authentications.java line 37: > 35: import javax.net.ssl.X509ExtendedKeyManager; > 36: > 37: class X509Auth

Re: RFR: 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code [v2]

2021-08-26 Thread Bradford Wetmore
On Fri, 27 Aug 2021 03:38:55 GMT, Xue-Lei Andrew Fan wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Codereview Comment > > src/java.base/share/classes/javax/net/ssl/SNIHostName.java line 37: > >> 35: import j

Re: RFR: 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code [v2]

2021-08-26 Thread Bradford Wetmore
> Did a quick sweep of some minor non-standard javadoc issues. This silences > 3rd party tooling warnings and fixes some linkage issues. Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revision: Codereview Comment - Changes:

Integrated: 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code

2021-08-26 Thread Bradford Wetmore
On Fri, 27 Aug 2021 01:35:17 GMT, Bradford Wetmore wrote: > Did a quick sweep of some minor non-standard javadoc issues. This silences > 3rd party tooling warnings and fixes some linkage issues. This pull request has now been integrated. Changeset: 76baace2 Author:Bradford Wetmore URL: