Re: RFR: 8275252: Migrate cacerts from JKS to password-less PKCS12

2021-10-18 Thread Magnus Ihse Bursie
On Thu, 14 Oct 2021 13:36:19 GMT, Weijun Wang wrote: > The cacerts file is now a password-less PKCS12 file. This make sure old code > that uses a JKS KeyStore object can continuously load it using a null > password (in fact, any password) and see all certificates inside. Marked as reviewed by

Re: RFR: 8275252: Migrate cacerts from JKS to password-less PKCS12

2021-10-18 Thread Magnus Ihse Bursie
On Fri, 15 Oct 2021 14:56:23 GMT, Weijun Wang wrote: >> If that means the build will become non-reproducible, then *I* certainly >> have thoughts about it! ;-) > > The certificate stored in a PKCS12 file has no date associated. Whenever you > load a keystore, the creation time is set to the loa

Re: RFR: 8274721: UnixSystem fails to provide uid, gid or groups if no username is available

2021-10-18 Thread Sean Mullan
On Mon, 4 Oct 2021 17:40:22 GMT, Weijun Wang wrote: > Two changes: > > 1. Calculation of groups is put in a separate block. > 2. Add fallback for uid and gid > > No regression test. Hard to reproduce bud reporter's environment in jtreg. Marked as reviewed by mullan (Reviewer). -

Integrated: 8274721: UnixSystem fails to provide uid, gid or groups if no username is available

2021-10-18 Thread Weijun Wang
On Mon, 4 Oct 2021 17:40:22 GMT, Weijun Wang wrote: > Two changes: > > 1. Calculation of groups is put in a separate block. > 2. Add fallback for uid and gid > > No regression test. Hard to reproduce bud reporter's environment in jtreg. This pull request has now been integrated. Changeset: a6

Re: RFR: 8272163: Add -version option to keytool and jarsigner [v2]

2021-10-18 Thread Hai-May Chao
On Fri, 15 Oct 2021 13:34:48 GMT, Weijun Wang wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix -version in jarsigner and update tests > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line

Re: RFR: 8272163: Add -version option to keytool and jarsigner [v2]

2021-10-18 Thread Hai-May Chao
> It'd be useful to have a -version option for keytool and jarsigner. Many > other JDK tools already have a -version option. This is to add -version > option to keytool and jarsigner like jar command does. > > CSR review: > https://bugs.openjdk.java.net/browse/JDK-8275174 Hai-May Chao has updat

Re: RFR: 8272163: Add -version option to keytool and jarsigner

2021-10-18 Thread Hai-May Chao
On Fri, 15 Oct 2021 13:49:27 GMT, Weijun Wang wrote: >> It'd be useful to have a -version option for keytool and jarsigner. Many >> other JDK tools already have a -version option. This is to add -version >> option to keytool and jarsigner like jar command does. >> >> CSR review: >> https://bug

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v6]

2021-10-18 Thread David Holmes
On Sat, 16 Oct 2021 11:11:59 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-419 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjd

Re: RFR: 8272163: Add -version option to keytool and jarsigner [v2]

2021-10-18 Thread Weijun Wang
On Tue, 19 Oct 2021 01:09:26 GMT, Hai-May Chao wrote: >> It'd be useful to have a -version option for keytool and jarsigner. Many >> other JDK tools already have a -version option. This is to add -version >> option to keytool and jarsigner like jar command does. >> >> CSR review: >> https://bu

Re: RFR: 8272163: Add -version option to keytool and jarsigner [v3]

2021-10-18 Thread Hai-May Chao
> It'd be useful to have a -version option for keytool and jarsigner. Many > other JDK tools already have a -version option. This is to add -version > option to keytool and jarsigner like jar command does. > > CSR review: > https://bugs.openjdk.java.net/browse/JDK-8275174 Hai-May Chao has updat

Re: RFR: 8272163: Add -version option to keytool and jarsigner [v2]

2021-10-18 Thread Hai-May Chao
On Tue, 19 Oct 2021 03:40:55 GMT, Weijun Wang wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix -version in jarsigner and update tests > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line

Re: RFR: 8272163: Add -version option to keytool and jarsigner [v4]

2021-10-18 Thread Hai-May Chao
> It'd be useful to have a -version option for keytool and jarsigner. Many > other JDK tools already have a -version option. This is to add -version > option to keytool and jarsigner like jar command does. > > CSR review: > https://bugs.openjdk.java.net/browse/JDK-8275174 Hai-May Chao has updat