Re: RFR: JDK-8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output

2021-12-10 Thread Martin Doerr
On Thu, 9 Dec 2021 08:25:17 GMT, Matthias Baesken wrote: > Please review this small test fix. > KeytoolOpensslInteropTest.java fails with the output below. > Seems on our SUSE Linux 15 (openssl is > ~> openssl version > OpenSSL 1.1.0i-fips 14 Aug 2018 > ) we get a slightly different output with a

Re: RFR: JDK-8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output

2021-12-10 Thread Matthias Baesken
On Fri, 10 Dec 2021 12:01:11 GMT, Martin Doerr wrote: > LGTM. Hi Martin, thanks for the review. - PR: https://git.openjdk.java.net/jdk/pull/6779

Re: RFR: JDK-8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output

2021-12-10 Thread Goetz Lindenmaier
On Thu, 9 Dec 2021 08:25:17 GMT, Matthias Baesken wrote: > Please review this small test fix. > KeytoolOpensslInteropTest.java fails with the output below. > Seems on our SUSE Linux 15 (openssl is > ~> openssl version > OpenSSL 1.1.0i-fips 14 Aug 2018 > ) we get a slightly different output with a

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v5]

2021-12-10 Thread Andrey Turbanov
> 8274809: Update java.base classes to use try-with-resources Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8274809: Update java.base classes to use try-with-resources move { to previous line - Changes: - all: h

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v4]

2021-12-10 Thread Andrey Turbanov
On Tue, 7 Dec 2021 07:59:54 GMT, Alan Bateman wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274809: Update java.base classes to use try-with-resources >> fix review comments > > src/java.base/share/classes/

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v4]

2021-12-10 Thread Andrey Turbanov
On Tue, 7 Dec 2021 14:48:17 GMT, Daniel Fuchs wrote: >Remind me to sponsor this after the fork. fork is done :) - PR: https://git.openjdk.java.net/jdk/pull/5818

Re: RFR: JDK-8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output

2021-12-10 Thread Thomas Stuefe
On Thu, 9 Dec 2021 08:25:17 GMT, Matthias Baesken wrote: > Please review this small test fix. > KeytoolOpensslInteropTest.java fails with the output below. > Seems on our SUSE Linux 15 (openssl is > ~> openssl version > OpenSSL 1.1.0i-fips 14 Aug 2018 > ) we get a slightly different output with a

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v4]

2021-12-10 Thread Andrey Turbanov
On Thu, 9 Dec 2021 01:25:20 GMT, Bradford Wetmore wrote: >> That's one of the places where I personally would always use the var keyword >> too: it makes the line shorter and the type is already clearly visible in >> the RHS of the assignment, so repeating it on the left hand side does not >>

RFR: 8278560: X509KeyManagerImpl::getAliases might return a good key with others

2021-12-10 Thread Weijun Wang
Perfect match does not always appear at the beginning if there are multiple KeyTypes. - Commit messages: - 8278560: X509KeyManagerImpl::getAliases might return a good key with others Changes: https://git.openjdk.java.net/jdk/pull/6804/files Webrev: https://webrevs.openjdk.java.net