Could you please review the JDK-8255739 bug fix?
I think sun.security.x509.SubjectAlternativeNameExtension() should throw an
exception for incorrect SubjectAlternativeNames instead of returning the
substituted characters, which is explained in the description of BugDB.
I modified DerValue.readS
SonarCloud reports:
A "Map" cannot contain a "String" in a "ServiceKey" type.
// clean up old alias if present
Service prevAliasService = legacyMap.get(aliasAlg);
Should be `aliasKey`, like other accesses to `legacyMap`. This code is
introduced by [JDK-8276660](https://bugs.openjdk.
On Thu, 23 Dec 2021 13:33:26 GMT, Aleksey Shipilev wrote:
> SonarCloud reports:
> A "Map" cannot contain a "String" in a "ServiceKey"
> type.
>
>
> // clean up old alias if present
> Service prevAliasService = legacyMap.get(aliasAlg);
>
>
> Should be `aliasKey`, like other accesse
> SonarCloud reports:
> A "Map" cannot contain a "String" in a "ServiceKey"
> type.
>
>
> // clean up old alias if present
> Service prevAliasService = legacyMap.get(aliasAlg);
>
>
> Should be `aliasKey`, like other accesses to `legacyMap`. This code is
> introduced by
> [JDK-8276
On Thu, 23 Dec 2021 13:42:41 GMT, Alan Bateman wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> comm
On Thu, 23 Dec 2021 18:51:22 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/java/security/Provider.java line 1152:
>>
>>> 1150: case ADD:
>>> 1151: // clean up old alias if present
>>> 1152: Service prevAliasService =
>>> legacyMa
On Fri, 10 Dec 2021 18:18:02 GMT, Andrey Turbanov wrote:
>> This is legacy code with probably poor testing coverage. Usually we don't
>> print anything on the console directly and unconditionally - except in some
>> well identified cases. Ignoring exceptions thrown by `close` is a common
>> id
On Wed, 22 Dec 2021 09:07:24 GMT, Sergey Bylokhov wrote:
> This bug is similar to https://bugs.openjdk.java.net/browse/JDK-8244094
>
> Currently, some of the files in the OpenJDK repo have Amazon copyright
> notices which are all slightly different and do not conform to Amazons
> preferred cop
> All TLS 1.3 handshakes in compatibility mode must send a non-empty SessionID
> field. Currently TLS1.3 session resumptions are sending empty session ID.
> This patch fixes that problem.
>
> All jdk_core tests passed. The newly added check passes with the patch, fails
> without it.
Daniel Jel
On Tue, 21 Dec 2021 21:25:53 GMT, Anthony Scarpino
wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright year
>
> Please add " 2021," to the copyright of ResumeTLS13withSNI.java.
> I have run all the
On Thu, 23 Dec 2021 21:47:53 GMT, Daniel Jeliński wrote:
>> All TLS 1.3 handshakes in compatibility mode must send a non-empty SessionID
>> field. Currently TLS1.3 session resumptions are sending empty session ID.
>> This patch fixes that problem.
>>
>> All jdk_core tests passed. The newly add
On Wed, 22 Dec 2021 09:07:24 GMT, Sergey Bylokhov wrote:
> This bug is similar to https://bugs.openjdk.java.net/browse/JDK-8244094
>
> Currently, some of the files in the OpenJDK repo have Amazon copyright
> notices which are all slightly different and do not conform to Amazons
> preferred cop
On Mon, 29 Nov 2021 08:42:22 GMT, Daniel Jeliński wrote:
> All TLS 1.3 handshakes in compatibility mode must send a non-empty SessionID
> field. Currently TLS1.3 session resumptions are sending empty session ID.
> This patch fixes that problem.
>
> All jdk_core tests passed. The newly added ch
> This bug is similar to https://bugs.openjdk.java.net/browse/JDK-8244094
>
> Currently, some of the files in the OpenJDK repo have Amazon copyright
> notices which are all slightly different and do not conform to Amazons
> preferred copyright notice which is simply (intentionally without copyri
14 matches
Mail list logo
