Looks good to me, removes credentials when phantom reachable, doesn't do
anything that would prevent it from becoming reachable. You removed the
GNSSException that wasn't thrown.
Regards,
Peter.
On 7/04/2022 2:17 pm, Xue-Lei Andrew Fan wrote:
Please review the update to remove finalizer
On Thu, 7 Apr 2022 04:10:55 GMT, Xue-Lei Andrew Fan wrote:
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
On Fri, 1 Apr 2022 07:32:21 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try'
> statement`
This pull request
On Thu, 7 Apr 2022 07:52:29 GMT, Andrey Turbanov wrote:
>> Let's take advantage of Java 7 language feature - "Catching Multiple
>> Exception Types".
>> It simplifies code. Reduces duplication.
>> Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try'
>> statement`
>
> Andrey
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try'
> statement`
Andrey Turbanov has updated the pull request incrementally with one
On Tue, 5 Apr 2022 10:27:54 GMT, Mahendra Chhipa wrote:
> Updated java/net and sun/net/www tests to remove dependency on
> sun.net.www.MessageHeader.
This pull request has now been integrated.
Changeset: ec73c61d
Author:Mahendra Chhipa
Committer: Daniel Fuchs
URL:
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
Update
On Thu, 31 Mar 2022 20:15:35 GMT, Xue-Lei Andrew Fan wrote:
> Please review the update to remove finalizer method in the SunJSSE provider
> implementation. It is one of the efforts to clean up the use of finalizer
> method in JDK.
Need an update, close the review for now.
-
PR:
On Thu, 31 Mar 2022 20:15:35 GMT, Xue-Lei Andrew Fan wrote:
> Please review the update to remove finalizer method in the SunJSSE provider
> implementation. It is one of the efforts to clean up the use of finalizer
> method in JDK.
This pull request has been closed without being integrated.
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
the object
Hello,
I think this proposal be very powerful, it allows completely new models (like
custom sandboxed VMs) while still removing many of the complicated classes.
I am all for it, but it does limit the actual work saved since the doPriveleged
and checkPermission sites are the thing which is the
On Thu, 31 Mar 2022 20:15:35 GMT, Xue-Lei Andrew Fan wrote:
> Please review the update to remove finalizer method in the SunJSSE provider
> implementation. It is one of the efforts to clean up the use of finalizer
> method in JDK.
The socket close() call in the finalize() method may be
> Please review the update to remove finalizer method in the SunJSSE provider
> implementation. It is one of the efforts to clean up the use of finalizer
> method in JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with two
additional commits since the last revision:
-
On Thu, 7 Apr 2022 15:48:50 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.security.jgss/share/classes/sun/security/jgss/wrapper/GSSCredElement.java
>> line 74:
>>
>>> 72: name = srcName;
>>> 73:
>>> 74: Cleaner.create().register(this, this::dispose);
>>
>> This will create a
Hi David,
Thanks for the feedback and spending some time on this proposal. Some
specific comments below.
On 4/5/22 9:52 AM, David Lloyd wrote:
Here at Red Hat there have been serious discussions about the impacts
of security manager removal on our users, and whether there is an
actual value
On Thu, 7 Apr 2022 17:54:35 GMT, Xue-Lei Andrew Fan wrote:
>> Hmm, the earlier JCE change would also needs to be updated as it calls a
>> cleanup method on the to-be-cleaned object.
>
>> Hmm, the earlier JCE change would also needs to be updated as it calls a
>> cleanup method on the
On Thu, 7 Apr 2022 19:21:31 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally
On Thu, 7 Apr 2022 17:35:47 GMT, Valerie Peng wrote:
> Hmm, the earlier JCE change would also needs to be updated as it calls a
> cleanup method on the to-be-cleaned object.
Yes, I will check the cleaner used in the security components and make sure
there is object reference problems.
On Tue, 8 Mar 2022 23:22:56 GMT, Mark Powers wrote:
> https://bugs.openjdk.java.net/browse/JDK-8234128
>
> My initial attempt had too many bad side-effects. This latest fix only tries
> to suppress the warning message.
test/jdk/sun/security/tools/jarsigner/warnings/AliasNotInStoreTest2.java
On Tue, 8 Mar 2022 23:22:56 GMT, Mark Powers wrote:
> https://bugs.openjdk.java.net/browse/JDK-8234128
>
> My initial attempt had too many bad side-effects. This latest fix only tries
> to suppress the warning message.
Looks good to me.
Yeah, the loop seems like it would behave the same way
On Thu, 7 Apr 2022 10:51:13 GMT, Daniel Fuchs wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
>
On Thu, 7 Apr 2022 10:51:13 GMT, Daniel Fuchs wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
>
On Tue, 8 Mar 2022 23:22:56 GMT, Mark Powers wrote:
> https://bugs.openjdk.java.net/browse/JDK-8234128
>
> My initial attempt had too many bad side-effects. This latest fix only tries
> to suppress the warning message.
I recall that Max said the intermediate was not necessary. Maybe he can
On Tue, 8 Mar 2022 23:22:56 GMT, Mark Powers wrote:
> https://bugs.openjdk.java.net/browse/JDK-8234128
>
> My initial attempt had too many bad side-effects. This latest fix only tries
> to suppress the warning message.
This pull request has now been integrated.
Changeset: d6f01e9d
Author:
On Thu, 7 Apr 2022 19:21:31 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally
On Thu, 7 Apr 2022 19:21:31 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally
On Thu, 7 Apr 2022 22:49:24 GMT, Bradford Wetmore wrote:
> > The socket close() call in the finalize() method may be blocked for the SSL
> > implementation, which is not good for garbage collection. It should be safe
> > by just removing the finalize() method.
`>
> Can you provide more
Hi Sean,
In order to keep our code up to date with Java, we need to replace
access control functionality. Current advise is that we will need to
instrument the Java API, once finalizers have been removed.
The sticking point is about the retention of permission checks, which
haven't been
On Thu, 7 Apr 2022 20:00:00 GMT, Weijun Wang wrote:
> I'm not sure if it's possible to write a test on the cleanup, but at least we
> can temporarily add a `println` line there and see if it ever gets called.
I did not find a way to test cleanup yet. Yes, a temporary 'println" is what I
can
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
On Thu, 7 Apr 2022 20:11:25 GMT, Xue-Lei Andrew Fan wrote:
> The socket close() call in the finalize() method may be blocked for the SSL
> implementation, which is not good for garbage collection. It should be safe
> by just removing the finalize() method.
Can you provide more detail? I
31 matches
Mail list logo
