On Sat, 9 Apr 2022 11:52:01 GMT, Alan Bateman wrote:
> What is the existing behavior with the BaseSSLSocketImpl finalizer? Does it
> just close the socket or does it to the close_notify before closing the
> socket. If it does, and you want to keep that behavior, then you are probably
> into
On Sat, 9 Apr 2022 06:22:51 GMT, Xue-Lei Andrew Fan wrote:
> Could you have more details? I did not catch the comment about
> NativeGSSContext.
When `NativeGSSContext(GSSNameElement peer, GSSCredElement myCred, int time,
GSSLibStub stub)` is called, `pContext` is 0 and you haven't registered
On Sat, 9 Apr 2022 14:59:13 GMT, Xue-Lei Andrew Fan wrote:
> The existing behavior is trying to close the socket and send the
> close_notify. As the socket closure has been done in the SocketImpl, I think
> BaseSSLSocketImpl could rely on to the SocketImpl cleaner. So the left for
> the
On Fri, 8 Apr 2022 13:50:25 GMT, Weijun Wang wrote:
> You might try it on other objects:
Nice idea to test object collection. I added two test cases.
> The `NativeGSSContext` code still needs to be fixed.
Could you have more details? I did not catch the comment about
NativeGSSContext.
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev
On Fri, 8 Apr 2022 22:55:07 GMT, Bradford Wetmore wrote:
> @AlanBateman, @dfuch, @bchristi-git, any great ideas here?
As you have found, if an open Socket is unreferenced then a cleaner can close
the underlying socket (and release the file descriptor). The Cleaner is setup
by the SocketImpl
