Integrated: 8286773: cleanup @returns in sun.security classes

2022-05-14 Thread John Jiang
On Sat, 14 May 2022 13:41:38 GMT, John Jiang wrote: > The below sun.security classes should use `@return` rather than `@returns`. > sun/security/tools/keytool/Main.java > sun/security/util/DerValue.java This pull request has now been integrated. Changeset: 63bd3b77 Author:John Jiang URL:

Re: RFR: 8283577: SSLEngine.unwrap on read-only input ByteBuffer [v2]

2022-05-14 Thread Xue-Lei Andrew Fan
On Sat, 14 May 2022 03:29:14 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review of this fix to allow a read-only 'src' buffer to be used >> with SSLEngine.unwrap(). A temporary read-write buffer is created in the >> SSLCipher operation when a read-only buffer is passed. If the 'src'

RFR: 8286773: cleanup @returns in sun.security classes

2022-05-14 Thread John Jiang
The below sun.security classes should use `@return` rather than `@returns`. sun/security/tools/keytool/Main.java sun/security/util/DerValue.java - Commit messages: - 8286773: cleanup @returns in sun.security classes Changes: https://git.openjdk.java.net/jdk/pull/8714/files Webrev:

Re: RFR: 8286773: cleanup @returns in sun.security classes

2022-05-14 Thread Xue-Lei Andrew Fan
On Sat, 14 May 2022 13:41:38 GMT, John Jiang wrote: > The below sun.security classes should use `@return` rather than `@returns`. > sun/security/tools/keytool/Main.java > sun/security/util/DerValue.java Looks good to me. - Marked as reviewed by xuelei (Reviewer). PR: