On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Marked as reviewed by lancea (Reviewer).
-
PR:
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Marked as reviewed by lancea (Reviewer).
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Looked at
-java.security.jgss.
LGTM
Replaces usages of articles that follow each other in all combinations: a/the,
an?/an?, the/the…
Also, I fixed a couple of spelling mistakes.
-
Commit messages:
- 8284191: Replace usages of 'the an' in hotspot and java.base
- 8284191: Replace usages of 'the an' in hotspot and
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Looked at
- java.base/.../sun/security
- jdk.crypto.*
- test/*/com/sun/crypto/provider
A new API to execute kinit.
-
Commit messages:
- 8286969: Add a new test library API to execute kinit in SecurityTools.java
Changes: https://git.openjdk.java.net/jdk/pull/8775/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8775=00
Issue:
Replaces usages of articles that follow each other in all combinations: a/the,
an?/an?, the/the…
It's the last issue in the series, and it still touches different areas of the
code.
-
Commit messages:
- 8284209: Replace remaining usages of 'the a' in source code
- 8284209:
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Marked as reviewed by iris (Reviewer).
-
PR:
On Tue, 17 May 2022 19:56:22 GMT, Weijun Wang wrote:
> Let ECDSA's `engineGetParameters()` always return null. At the same time,
> remove the remembered `sigParams` field. One behavior change is that after
> calling `setParameter()`, one can call `init()` again with a key using
> different
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Logging/JNDI OK
-
Marked as
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
LGTM for i18n changes.
-
Marked as reviewed by naoto (Reviewer).
PR:
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()` with `List.of()` is dubious as
> the latter is
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Marked as reviewed by iris (Reviewer).
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
javac and javadoc changes look OK
On Wed, 18 May 2022 16:19:40 GMT, Sibabrata Sahoo wrote:
> A new API to execute kinit.
Marked as reviewed by rhalade (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8775
On Wed, 18 May 2022 22:27:18 GMT, Weijun Wang wrote:
>> Let ECDSA's `engineGetParameters()` always return null. At the same time,
>> remove the remembered `sigParams` field. One behavior change is that after
>> calling `setParameter()`, one can call `init()` again with a key using
>>
On Tue, 17 May 2022 23:11:06 GMT, Weijun Wang wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more minor cleanups for consistencies.
>
> src/java.base/share/classes/java/security/SignatureSpi.java line 377:
>
>>
> Let ECDSA's `engineGetParameters()` always return null. At the same time,
> remove the remembered `sigParams` field. One behavior change is that after
> calling `setParameter()`, one can call `init()` again with a key using
> different parameters. I think this should be allowed since we are
On Wed, 18 May 2022 22:27:18 GMT, Weijun Wang wrote:
>> Let ECDSA's `engineGetParameters()` always return null. At the same time,
>> remove the remembered `sigParams` field. One behavior change is that after
>> calling `setParameter()`, one can call `init()` again with a key using
>>
On Wed, 18 May 2022 16:19:40 GMT, Sibabrata Sahoo wrote:
> A new API to execute kinit.
Marked as reviewed by weijun (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8775
> This is to update the method javadoc of
> java.security.Signature.getParameters() with the missing `@throws
> UnsupportedOperationException`. In addition, the wording on the returned
> parameters are updated to match those in Cipher and CipherSpi classes.
>
> CSR will be filed later.
>
>
On Wed, 18 May 2022 04:47:13 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8284688
>>
>> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the
>> umbrella bug for this bug. The changes were too large for a single code
>> review, so it was decided to
On Wed, 18 May 2022 04:47:13 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8284688
>>
>> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the
>> umbrella bug for this bug. The changes were too large for a single code
>> review, so it was decided to
> Let ECDSA's `engineGetParameters()` always return null. At the same time,
> remove the remembered `sigParams` field. One behavior change is that after
> calling `setParameter()`, one can call `init()` again with a key using
> different parameters. I think this should be allowed since we are
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()` with `List.of()` is dubious as
> the latter is
On Mon, 16 May 2022 15:29:38 GMT, Сергей Цыпанов wrote:
>> Even in the no exceptions case, the `exceptionTypes` array still has to be
>> allocated/copied by `Method.getExceptionTypes()`[^1] when the `ProxyMethod`
>> constructor[^2] is invoked.
>>
>> So if anything, the `List.of(…)` call
26 matches
Mail list logo