Re: RFR: JDK-8288207: Enhance MalformedURLException in Uri.parseCompat

2022-06-13 Thread Matthias Baesken
On Fri, 10 Jun 2022 14:19:27 GMT, Daniel Fuchs wrote: > I might question whether the added "null:-1" information is really helpful, > or just as confusing however. Hi Daniel, should we maybe better print something like "check for not allowed characters" in the exception ? Do you have an easy a

Re: RFR: 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest [v2]

2022-06-13 Thread Sean Mullan
On Sat, 11 Jun 2022 03:30:45 GMT, Kevin Driver wrote: >> This PR resolves: https://bugs.openjdk.org/browse/JDK-8267860 > > Kevin Driver has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the mer

Re: RFR: JDK-8288207: Enhance MalformedURLException in Uri.parseCompat

2022-06-13 Thread Jaikiran Pai
On Mon, 13 Jun 2022 07:26:32 GMT, Matthias Baesken wrote: > Hi Daniel, should we maybe better print something like "check for not allowed > characters" in the exception ? Do you have an easy and cheap way in mind to > the get the unsupported character (in this case "_") to add it to the output

Integrated: 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest

2022-06-13 Thread Kevin Driver
On Fri, 10 Jun 2022 17:12:30 GMT, Kevin Driver wrote: > This PR resolves: https://bugs.openjdk.org/browse/JDK-8267860 This pull request has now been integrated. Changeset: 2adef6a1 Author:Kevin Driver Committer: Bradford Wetmore URL: https://git.openjdk.org/jdk/commit/2adef6a1f84d4

Re: RFR: JDK-8288207: Enhance MalformedURLException in Uri.parseCompat

2022-06-13 Thread Matthias Baesken
On Mon, 13 Jun 2022 14:29:44 GMT, Jaikiran Pai wrote: > > Hi Daniel, should we maybe better print something like "check for not > > allowed characters" in the exception ? Do you have an easy and cheap way in > > mind to the get the unsupported character (in this case "_") to add it to > > the

RFR: 8288209: SSL debug message wrong about unsupported authentication scheme

2022-06-13 Thread Weijun Wang
At the beginning, this bug was about the incorrect warning message "Unsupported authentication scheme" on line 1051 which should have been "This key algorithm has been checked, skip it". Now, it's a code refactoring that emphasizes only the key algorithm inside a signature scheme is checked in