Re: CR 6911951 Updated, weijun.wang now responsible engineer, P4 java/classes_secu NTLM should be a supported Java SASL mechanism

2010-04-15 Thread Weijun Wang
Vinnie Please take a review on this webrev: cr.openjdk.java.net/~weijun/6911951/webrev.00/ I've updated the spec a little by making NTLMv2 as the default version. It has been supported for a long time and now default with Windows 7 and Server 2008 R2. Networking guys, are you OK with the r

Re: Permission Bug in AtomicLongFieldUpdater and AtomicIntegerFieldUpdater

2010-04-15 Thread David Holmes
Martin Buchholz said the following on 04/16/10 11:38: On Thu, Apr 15, 2010 at 17:49, David Holmes wrote: If this proceeds I think you need to include AtomicReferenceFieldUpdater in this as well. Agreed. I may have created some confusion because the test in my webrev did not actually demonstr

Re: Permission Bug in AtomicLongFieldUpdater and AtomicIntegerFieldUpdater

2010-04-15 Thread David Holmes
Hi Martin, If this proceeds I think you need to include AtomicReferenceFieldUpdater in this as well. But this is not a clear cut issue (security never is!). If I understand the test program correctly the problem arises when the target object's class was loaded by a different class-loader to

hg: jdk7/tl/jdk: 6939248: Jarsigner can't extract Extended Key Usage from Timestamp Reply correctly

2010-04-15 Thread weijun . wang
Changeset: 0d989dc383d3 Author:weijun Date: 2010-04-16 10:13 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d989dc383d3 6939248: Jarsigner can't extract Extended Key Usage from Timestamp Reply correctly Reviewed-by: xuelei, mullan ! src/share/classes/sun/security/tools/Tim

hg: jdk7/tl/jdk: 6937978: let keytool -gencert generate the chain

2010-04-15 Thread weijun . wang
Changeset: db4fd2fdf196 Author:weijun Date: 2010-04-16 10:06 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db4fd2fdf196 6937978: let keytool -gencert generate the chain Reviewed-by: mullan ! src/share/classes/sun/security/tools/KeyTool.java ! test/sun/security/tools/keytool

Re: Permission Bug in AtomicLongFieldUpdater and AtomicIntegerFieldUpdater

2010-04-15 Thread Martin Buchholz
On Thu, Apr 15, 2010 at 17:49, David Holmes wrote: > Hi Martin, > > If this proceeds I think you need to include AtomicReferenceFieldUpdater in > this as well. Agreed. I may have created some confusion because the test in my webrev did not actually demonstrate the problem. I have since fixed tha

hg: jdk7/tl/jdk: 6931676: TEST_BUG: wrong value for bugid in comments

2010-04-15 Thread xueming . shen
Changeset: c70d4266d474 Author:sherman Date: 2010-04-15 17:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c70d4266d474 6931676: TEST_BUG: wrong value for bugid in comments Summary: update to the correct bugid Reviewed-by: martin ! test/java/util/regex/RegExTest.java

Re: [PATCH FOR REVIEW]: Improve error output for NSS provider

2010-04-15 Thread Bradford Wetmore
Hi Andrew, I couldn't tell for sure if this was for OpenJDK 7 or OpenJDK 6. I'm assuming the former? Looks good. I checked for any remaining missing CKR_* values in the PKCS11 spec version 2.20, this covers all the missing values. I've filed: 6944361: Missing CKR_ values in PKCS11Exception O

Permission Bug in AtomicLongFieldUpdater and AtomicIntegerFieldUpdater

2010-04-15 Thread Martin Buchholz
Hi java.util.concurrent security team, People are using Atomic field updaters to update fields in classes in other classloaders. Toby writes: We received a bug report for App Engine that AtomicLongFieldUpdater (and its sibling) were failing with RuntimePermission accessDeclaredMembers. Looking a

Re: [PATCH FOR REVIEW]: Improve error output for NSS provider

2010-04-15 Thread Bradford Wetmore
Sure. I'm finally coming up for air before I dive back into some longer term projects, so I can take care of this. Brad On 4/15/2010 12:01 PM, Valerie (Yu-Ching) Peng wrote: > > I've looked at the changes and they look fine to me. If you can work w/ > Andrew to get this in, e.g. bug id, integr

Re: [PATCH FOR REVIEW]: Improve error output for NSS provider

2010-04-15 Thread Valerie (Yu-Ching) Peng
I've looked at the changes and they look fine to me. If you can work w/ Andrew to get this in, e.g. bug id, integration, etc., that'd be good. Thanks, Valerie On 04/14/10 23:49, Bradford Wetmore wrote: Valerie, did you want to look at this, or I can work with Andrew on getting this in. It's

hg: jdk7/tl/jdk: 6943219: test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java fail in linux

2010-04-15 Thread chris . hegarty
Changeset: ed61accf772e Author:chegar Date: 2010-04-15 16:37 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ed61accf772e 6943219: test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java fail in linux Reviewed-by: andrew ! test/sun/security/s

Re: [PATCH FOR REVIEW]: Improve error output for NSS provider

2010-04-15 Thread Andrew John Hughes
On 15 April 2010 07:49, Bradford Wetmore wrote: > Valerie, did you want to look at this, or I can work with Andrew on > getting this in.  It's pretty straightforward. > Just to clarify; I have push access so I just need approval and a bug ID to commit the change. > Brad > > > On 4/12/2010 8:49 A

Re: Code Review 6943219: test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java fail in linux

2010-04-15 Thread Xuelei Fan
Looks fine to me. Thanks, Andrew On 4/15/2010 5:05 PM, Chris Hegarty wrote: > Hi Andrew, > > These tests have canned certs with 'localhost' as a subject alternative > name in the client certificate. This fails client authentication on the > accepted server socket if the platform returns anything

Code Review 6943219: test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java fail in linux

2010-04-15 Thread Chris Hegarty
Hi Andrew, These tests have canned certs with 'localhost' as a subject alternative name in the client certificate. This fails client authentication on the accepted server socket if the platform returns anything other than 'localhost' for the remote address. This can happen on Linux which typi