Re: Relook at 6937978: let keytool -gencert generate the chain

2011-01-21 Thread Xuelei Fan
OK. Thanks, Xuelei On 1/21/2011 4:23 PM, Weijun Wang wrote: On 01/21/2011 04:12 PM, Xuelei Fan wrote: Is there any impact on the return value of KeyStore.getCertificateChain(String)? Nothing. This method returns what's actually inside the KeyStore entry. My proposal only make the

Re: code review request for CR 6989705: ECC security code native code compiler warnings

2011-01-21 Thread Alan Bateman
Vincent Ryan wrote: Hello Alan, Please review the following webrev which removes 100's of nuisance compiler warnings generated by our ECC code: http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/ Getting rid of the #pragmas and the other changes look okay to me. The only

Re: code review request for CR 6989705: ECC security code native code compiler warnings

2011-01-21 Thread Vincent Ryan
On 21/01/2011 14:42, Alan Bateman wrote: Vincent Ryan wrote: Hello Alan, Please review the following webrev which removes 100's of nuisance compiler warnings generated by our ECC code: http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/ Getting rid of the #pragmas and

Re: code review request for CR 6989705: ECC security code native code compiler warnings

2011-01-21 Thread Kelly O'Hair
On Jan 21, 2011, at 7:08 AM, Vincent Ryan wrote: On 21/01/2011 14:42, Alan Bateman wrote: Vincent Ryan wrote: Hello Alan, Please review the following webrev which removes 100's of nuisance compiler warnings generated by our ECC code:

hg: jdk7/tl/jdk: 2 new changesets

2011-01-21 Thread mandy . chung
Changeset: f26d1a7fe4d2 Author:mchung Date: 2011-01-21 09:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f26d1a7fe4d2 6912013: Remove the temporary launcher fix to add modules in the bootclasspath Reviewed-by: ksrini ! src/share/bin/java.c ! src/share/bin/java.h !

hg: jdk7/tl/jdk: 2 new changesets

2011-01-21 Thread zhengyu . gu
Changeset: 2381e810330b Author:zgu Date: 2011-01-20 10:45 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2381e810330b 6983248: net/net001 and net/net003 fail on WinXP with JDK7-B108 Summary: Using closesocket to close socket handler to avoid invalid C runtime parameter