Re: RFR 7191662: JCE providers should be located via ServiceLoader

2015-05-28 Thread Valerie Peng
Please find comments in line... On 5/27/2015 3:42 PM, Mandy Chung wrote: Valerie, Did you see my comment yesterday? http://mail.openjdk.java.net/pipermail/security-dev/2015-May/012254.html Yes, we exchanged emails after this above one. I will follow up your latest one later today.

Re: [JEP-219/JDK-8043758] Code Review Request: Datagram Transport Layer Security (DTLS)

2015-05-28 Thread Sean Mullan
On 05/22/2015 12:41 PM, Xuelei Fan wrote: webrev:http://cr.openjdk.java.net/~xuelei/8043758/webrev.latest/ Updates: 1. Update to discard invalid records, rather than use an alert message, per the requirements in section 4.1.2.7, RFC 6374. 2. Update to use a base test class, simplify the test

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-28 Thread Valerie Peng
Please find comments in line. On 5/27/2015 4:40 PM, Mandy Chung wrote: On May 27, 2015, at 4:17 PM, Valerie Pengvalerie.p...@oracle.com wrote: Hi, Mandy, I have second thought on using the provider name for the java.security file... There are a few things that I want to discuss/brainstorm

Re: [JEP-219/JDK-8043758] Code Review Request: Datagram Transport Layer Security (DTLS)

2015-05-28 Thread Xuelei Fan
On 5/29/2015 4:17 AM, Sean Mullan wrote: On 05/22/2015 12:41 PM, Xuelei Fan wrote: webrev:http://cr.openjdk.java.net/~xuelei/8043758/webrev.latest/ Updates: 1. Update to discard invalid records, rather than use an alert message, per the requirements in section 4.1.2.7, RFC 6374. 2. Update

Re: RSA and Diffie-Hellman performance [Was: RFR(L): 8069539: RSA acceleration]

2015-05-28 Thread Andrew Haley
On 27/05/15 21:35, Anthony Scarpino wrote: How much of the montgomery multiply and sqaure are you planning to intrinsify? Are you doing the whole thing or just portions of the operations similar to multiplyToLen and squareToLen? I'm doing the whole montgomery multiply and square operation in

Re: RSA and Diffie-Hellman performance [Was: RFR(L): 8069539: RSA acceleration]

2015-05-28 Thread Andrew Haley
On 05/28/2015 08:51 AM, Andrew Haley wrote: On 27/05/15 21:35, Anthony Scarpino wrote: How much of the montgomery multiply and sqaure are you planning to intrinsify? Are you doing the whole thing or just portions of the operations similar to multiplyToLen and squareToLen? I'm doing the

RE: RFR: 8048830 - Implement tests for new functionality provided in JEP 166

2015-05-28 Thread Bhanu Prakash Gopularam
Please review the changes for JEP 166: In this webrev, I have updated test certificate fields to reflect proper test data. http://cr.openjdk.java.net/~asmotrak/bhanu/8048830/webrev.01/ Thanks, Bhanu From: Bhanu Prakash Gopularam Sent: Monday, May 25, 2015 8:43 PM To: