Re: RFR: 8046943: RSA Acceleration

2015-06-12 Thread Andrew Haley
On 06/12/2015 12:06 PM, Andrew Haley wrote: Sorry, I forgot the column labels. The are: signverifysign/s verify/s rsa 512 bits 0.000134s 0.09s 7444.2 111853.3 rsa 1024 bits 0.000674s 0.29s 1483.9 34456.9 rsa 2048 bits 0.003945s 0.000100s253.5

RFR: 8046943: RSA Acceleration

2015-06-12 Thread Andrew Haley
http://cr.openjdk.java.net/~aph/8046943-hs-1/ http://cr.openjdk.java.net/~aph/8046943-jdk-1/ Before: rsa 512 bits 0.000134s 0.09s 7444.2 111853.3 rsa 1024 bits 0.000674s 0.29s 1483.9 34456.9 rsa 2048 bits 0.003945s 0.000100s253.5 9994.7 rsa 4096 bits 0.027015s 0.000373s

Re: [PATCH] CipherStream produces new byte array on every update or doFinal operation

2015-06-12 Thread Sean Mullan
FYI, I created a bug to track this: https://bugs.openjdk.java.net/browse/JDK-8087327 --Sean On 02/20/2015 02:50 PM, Valerie Peng wrote: I started with this, but I have a pressing higher priority tasks at hand. So, it will take me a few weeks to wrap this up. Regards, Valerie On 2/17/2015

Re: RFR: 8073108: GHASH Intrinsics

2015-06-12 Thread Vladimir Kozlov
This implementation looks good to me. You need second review since changes are big. Thanks, Vladimir On 6/11/15 11:01 AM, Anthony Scarpino wrote: Now that JEP 246 is targeted, I can proceed a with the GHASH changes I had reviewed back in February. There are two changes from the previous

Re: RFR: 8087283 : Add support for the XML Signature here() function to the JDK XPath implementation

2015-06-12 Thread huizhe wang
Hi Sean, The change looks good to me. Thanks, Joe On 6/12/2015 10:29 AM, Sean Mullan wrote: Please review this change to add support for the XML Signature here() function to the JDK XPath implementation. The here function is not defined in its own namespace. Therefore it needs to be

Re: RFR: 8087283 : Add support for the XML Signature here() function to the JDK XPath implementation

2015-06-12 Thread Alan Bateman
On 12/06/2015 18:29, Sean Mullan wrote: Please review this change to add support for the XML Signature here() function to the JDK XPath implementation. The here function is not defined in its own namespace. Therefore it needs to be implemented by extending the function library of XPath in the

RFR: 8087283 : Add support for the XML Signature here() function to the JDK XPath implementation

2015-06-12 Thread Sean Mullan
Please review this change to add support for the XML Signature here() function to the JDK XPath implementation. The here function is not defined in its own namespace. Therefore it needs to be implemented by extending the function library of XPath in the same namespace. Currently, the JDK XML

Re: [PATCH] CipherStream produces new byte array on every update or doFinal operation

2015-06-12 Thread Valerie Peng
Thanks! I have test/modified the patch locally but have yet to create a bug to track it. Valerie On 6/12/2015 4:52 AM, Sean Mullan wrote: FYI, I created a bug to track this: https://bugs.openjdk.java.net/browse/JDK-8087327 --Sean On 02/20/2015 02:50 PM, Valerie Peng wrote: I started