Re: [9] RFR(M): 8076112: Add @HotSpotIntrinsicCandidate annotation to indicate methods for which Java Runtime has intrinsics

2015-07-01 Thread Zoltán Majó
Hi, thank you, everyone, for the comments/suggestions/feedback! If no other issues come up, I intend to push the latest webrev (webrev.07) on Thursday (July 2). Best regards, Zoltan

Re: RFR: 8130150: RSA Acceleration

2015-07-01 Thread Vladimir Kozlov
Looks good to me. Thanks, Vladimir On 7/1/15 7:56 AM, Andrew Haley wrote: Sorry for the mistake. New webrevs: http://cr.openjdk.java.net/~aph/8130150-hs-1/ http://cr.openjdk.java.net/~aph/8130150-jdk-1/ Andrew.

Re: RFR 8098854: Do cleanup in a proper order in mscapi

2015-07-01 Thread Ivan Gerasimov
Hello! Would someone please help review this small cleanup fix? I'll go on vacation in a week, and I would like to push it before then. Sincerely yours, Ivan On 19.06.2015 22:17, Ivan Gerasimov wrote: Hello everyone! The changeset consists of two parts: - checking systematically for NULL

RE: RFR: 8048830 - Implement tests for new functionality provided in JEP 166

2015-07-01 Thread Bhanu Prakash Gopularam
Hello, Please review changes for JEP 166: Test for storing and validating the secret key entries in keystore is merged into test/sun/security/pkcs12/StoreSecretKeyTest.java and the test certificate files are regenerated with valid identity information. HYPERLINK

Re: RFR: 8130150: RSA Acceleration

2015-07-01 Thread Andrew Haley
On 06/30/2015 06:49 PM, Andrew Haley wrote: New webrevs: http://cr.openjdk.java.net/~aph/8130150-jdk http://cr.openjdk.java.net/~aph/8130150-hs/ I made an error when preparing these webrevs. Please ignore. Andrew.

Re: RFR: 8130150: RSA Acceleration

2015-07-01 Thread Andrew Haley
Sorry for the mistake. New webrevs: http://cr.openjdk.java.net/~aph/8130150-hs-1/ http://cr.openjdk.java.net/~aph/8130150-jdk-1/ Andrew.

Re: RFR 8098854: Do cleanup in a proper order in mscapi

2015-07-01 Thread Ivan Gerasimov
On 01.07.2015 20:08, Vincent Ryan wrote: Your fix looks fine to me. Thanks. Thank you Vincent! On 1 Jul 2015, at 18:04, Ivan Gerasimov ivan.gerasi...@oracle.com wrote: Hello! Would someone please help review this small cleanup fix? I'll go on vacation in a week, and I would like to push

New status code in SSLEngineResult.HandshakeStatus

2015-07-01 Thread David M. Lloyd
It has caused some consternation among certain of our engineers that there is a new possible status code in SSLEngineResult.HandshakeStatus. If a new status were generally added, it would cause subtle or not so subtle breakage amount current SSLEngine consumers. I request that it be made

Re: RFR 8098854: Do cleanup in a proper order in mscapi

2015-07-01 Thread Vincent Ryan
Your fix looks fine to me. Thanks. On 1 Jul 2015, at 18:04, Ivan Gerasimov ivan.gerasi...@oracle.com wrote: Hello! Would someone please help review this small cleanup fix? I'll go on vacation in a week, and I would like to push it before then. Sincerely yours, Ivan On 19.06.2015