Re: [9]RFR 6946830: javax.crypto.Cipher.doFinal behavior differs depending on platform

I like the new update. Thanks! Xuelei On 9/23/2016 5:59 AM, Valerie Peng wrote: Ok, I think this should be better: http://cr.openjdk.java.net/~valeriep/6946830/webrev.01/src/jdk.crypto.pkcs11/share/classes/sun/security/pkcs11/P11Cipher.java.sdiff.html Made some minor changes for clean up

Re: [9]RFR 6946830: javax.crypto.Cipher.doFinal behavior differs depending on platform

Ok, I think this should be better: http://cr.openjdk.java.net/~valeriep/6946830/webrev.01/src/jdk.crypto.pkcs11/share/classes/sun/security/pkcs11/P11Cipher.java.sdiff.html Made some minor changes for clean up as well. Thanks, Valerie On 9/19/2016 6:20 PM, Xuelei Fan wrote: P11Cipher.java

Re: RFR: JDK-8049516: sun.security.provider.SeedGenerator throws ArrayIndexOutOfBoundsException

Looks fine to me. Thanks! Xuelei On 9/22/2016 4:05 PM, Jamil Nimeh wrote: That's a very good suggestion. I've made that change and updated the webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8049516/webrev.02/ Thanks again, --Jamil On 09/21/2016 05:34 PM, Xuelei Fan wrote: > latch =

Re: RFR: JDK-8049516: sun.security.provider.SeedGenerator throws ArrayIndexOutOfBoundsException

That's a very good suggestion. I've made that change and updated the webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8049516/webrev.02/ Thanks again, --Jamil On 09/21/2016 05:34 PM, Xuelei Fan wrote: > latch = (latch + 1) & 0x7FFF; // Mask the sign bit I'm fine with it. BTW, if you

Re: [9]RFR 8136355: CKM_SSL3_KEY_AND_MAC_DERIVE no longer available by default on Solaris 12

Thanks! Regards, Sean. On 22 September 2016 00:40:15 GMT+01:00, Valerie Peng wrote: >Alright, I included the hex value of the version to the exception >message. >In addition, one of the regression test was using 0x400 as the version >value and that has to be removed