Code Review Request, JDK-8171337 Check for correct SSLEngineImpl/SSLSocketImpl.setSSLParameters handshaker update method

Hi Brad, Please review this handshake update method miss-use fix: http://cr.openjdk.java.net/~xuelei/8171337/webrev.00/ The activation process of handshake may consider the parameters in a big picture and make adjustment accordingly. Basically, SSL parameters should be configured before

Re: RFR 8171353: New home for SecurityTools.java test utility

Hi Max, I am fine with it. Artem On 12/16/2016 12:07 AM, Wang Weijun wrote: Hi Artem I hope you are OK with this change: diff --git a/test/lib/security/SecurityTools.java b/test/lib/testlibrary/jdk/testlibrary/SecurityTools.java rename from test/lib/security/SecurityTools.java rename to

Re: Code Review Request JDK-8129988 JSSE should create a single instance of the cacerts KeyStore

Hi Xuelei, First cut of a review at this. I still need to review TrustStoreManager, so will get back to you later on that. Looks very good so far. * KeyStores.java Do an 'hg rename' on this file, so you can see the diffs between this and the new name (TrustStoreUtil), and you preserve the

Re: [9] RFR 8170282: Enable ALPN parameters to be supplied during the TLS handshake

I’ve made the change to use activated() rather than started() in SSLEngineImpl and SSLSocketImpl and also the suggestions for ServerHandshaker. I’ve also updated the tests to check SSLEngine/SSLSocket.getHandshakeApplicationProtocolSelector. All tests pass. Thanks for all the review comments.

Re: RFR 8171340: HttpNegotiateServer/java test should not use system proxy on Mac

On 16/12/16 03:43, Wang Weijun wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8171340/webrev.00/ All "openConnection()" modified to "openConnection(Proxy.NO_PROXY)". Thank you Max. Reviewed. -Chris.

RFR 8171353: New home for SecurityTools.java test utility

Hi Artem I hope you are OK with this change: diff --git a/test/lib/security/SecurityTools.java b/test/lib/testlibrary/jdk/testlibrary/SecurityTools.java rename from test/lib/security/SecurityTools.java rename to test/lib/testlibrary/jdk/testlibrary/SecurityTools.java ---