All,
Apologies... I had only read the top of the patch before replying.
All my comments had already been addressed in the actual patch.
Sorry for the noise.
-chris
On 1/12/18 6:00 PM, Christopher Schultz wrote:
> Adam and David,
>
> On 1/8/18 11:30 AM, Adam Petcher wrote:
>> On 1/8/2018
Adam and David,
On 1/8/18 11:30 AM, Adam Petcher wrote:
> On 1/8/2018 10:13 AM, David CARLIER wrote:
>
>> Hi,
>>
>> Here a little patch proposal which is usually relevant in
>> cryptographics matters. Usually memset/bzero/... is used to clear
>> private structures but the compiler can possibly
On 1/9/18 8:40 PM, Weijun Wang wrote:
The code can also throw GeneralSecurityException but those are also always
suppressed because of the catch block. Is that the right behavior?
Not a right behavior but should be harmless here. In my understanding, in the
case of PBE, as long the
Hi,
here is the next patch for brainpool curve support in SunEC.
Differences from the first patch:
* Brainpool curves with less than 256 bits are removed. Subsequently, the curve
oid check is made more robust to avoid null
pointer caused Segmentation Faults in memcmp calls.
* Bug JDK-8189594
On 12/01/2018 04:51, Amy Lu wrote:
Please review this minor test-tag-only change to move bugid from @test
to @bug
bug: https://bugs.openjdk.java.net/browse/JDK-8194959
webrev: http://cr.openjdk.java.net/~amlu/8194959/webrev.00/
Looks good.
