Hopefully the final set of updates before committing this feature:
* Updated the ChaChaEngine implementations in ChaCha20Cipher.java to
properly conform to Cipher's specification when the output buffer
used in doUpdate is too small. Instead of throwing
IndexOutOfBoundsException like
The updated webrev looks good. I have no further comments.
--Sean
On 5/22/18 4:43 PM, Jamil Nimeh wrote:
A couple updates:
* Touched up the comments surrounding init/wrap/unwrap methods. None
of these affect public javadocs.
* Added an implementation for engineGetParameters. This was
May I request you to review this fix to remove listed Symantec root
certificates.
Webrev: http://cr.openjdk.java.net/~rhalade/8191031/webrev.00/
Thanks,
Rajan
On 5/30/18 4:16 AM, Sean Mullan wrote:
Looks good,
thanks!
but can you also add a release note to the bug?
good catch! I will add the release note to it and to earlier fix as well.
Thanks,
Rajan
--Sean
On 5/30/18 1:11 AM, Rajan Halade wrote:
May I request you to review this fix to remove
Looks good.
--Sean
On 5/24/18 8:16 PM, Weijun Wang wrote:
On May 24, 2018, at 11:39 PM, Sean Mullan wrote:
I think the MGF1 based SignatureMethod algs should be named SHA256_RSA_MGF1,
etc to be consistent with the URI names in the RFC.
Updated.
I've also updated my local code, no new
On 5/29/18 8:18 PM, Weijun Wang wrote:
CSR approved. Please review the code change and release note.
Looks good.
--Sean
Thanks
Max
On May 26, 2018, at 6:06 PM, Weijun Wang wrote:
Please also review the release note at
https://bugs.openjdk.java.net/browse/JDK-8203846.
Thanks.
On May
Looks good, but can you also add a release note to the bug?
--Sean
On 5/30/18 1:11 AM, Rajan Halade wrote:
May I request you to review this fix to remove baltimorecodesigningca
from cacerts.
Webrev: http://cr.openjdk.java.net/~rhalade/8189949/webrev.00/
Thanks,
Rajan
