[14] RFR Release Note for JDK-8180392 "SunJCE provider should throw exceptions for unsupported mode and padding combinations"

2019-08-02 Thread Valerie Peng
Adding a release note as Sean suggested. Please review it at https://bugs.openjdk.java.net/browse/JDK-8229043 Thanks, Valerie

Re: RFR(S) JDK-8225625: AES Electronic Codebook (ECB) encryption and decryption optimizations using AVX512 + VAES instructions.

2019-08-02 Thread Valerie Peng
Changes to the ElectronicCodeBook.java looks fine to me. Thanks, Valerie* * On 7/31/2019 2:38 PM, Vladimir Kozlov wrote: Good. Lets wait review from security team. Thank you Vladimir On 7/31/19 2:20 PM, Rukmannagari, Shravya wrote: Hi Vladimir, Thanks a lot for the review. I have responded

Re: RFR CSR for 8162628: Migrating cacerts keystore to password-less PKCS12 format

2019-08-02 Thread Michael Osipov
Thank you, looking forward to. Am 2019-08-02 um 11:59 schrieb Weijun Wang: Great. This is also easy for me. --Max On Aug 2, 2019, at 5:20 PM, Michael Osipov <1983-01...@gmx.net> wrote: On Jun 1, 2019, at 7:17 PM, Michael Osipov <1983-01...@gmx.net> wrote: Can you please explain why not

Re: FRF[14] JDK-8228967: Trust/Key store and SSL context utilities for tests

2019-08-02 Thread Sean Mullan
Not a full review but there is already a utility class for creating certificates, etc in test/jdk/java/security/testlibrary/CertUtils.java Could you combine/merge that with your new CertUtils class? --Sean On 8/2/19 4:29 AM, sha.ji...@oracle.com wrote: Hi, This enhancement provides a set of

Re: RFR CSR for 8162628: Migrating cacerts keystore to password-less PKCS12 format

2019-08-02 Thread Weijun Wang
Great. This is also easy for me. --Max > On Aug 2, 2019, at 5:20 PM, Michael Osipov <1983-01...@gmx.net> wrote: > >>> On Jun 1, 2019, at 7:17 PM, Michael Osipov <1983-01...@gmx.net> wrote: >>> >>> Can you please explain why not simple PEM bundles like OpenSSL have been >>> chosen? >> >> Is

Re: Re: RFR CSR for 8162628: Migrating cacerts keystore to password-less PKCS12 format

2019-08-02 Thread Michael Osipov
> > On Jun 1, 2019, at 7:17 PM, Michael Osipov <1983-01...@gmx.net> wrote: > > > > Can you please explain why not simple PEM bundles like OpenSSL have been > > chosen? > > Is that /etc/ssl/certs on Ubuntu? It's a directory containing a lot of PEM > files. Do you prefer this style or a big file

FRF[14] JDK-8228967: Trust/Key store and SSL context utilities for tests

2019-08-02 Thread sha . jiang
Hi, This enhancement provides a set of utilities for creating certificate, trust/key store and SSL context. It provides the default trust and key stores with RSA, ECDSA, RSASSA-PSS and DSA certificates, and also the default TLS and DTLS contexts with the default trust and key stores. Three