Re: RFR: 8282932: a space is needed for the unsupported protocol exception message in ProtocolVersion

2022-03-09 Thread Xue-Lei Andrew Fan
On Thu, 10 Mar 2022 06:52:14 GMT, John Jiang wrote: > In class sun.security.ssl.ProtocolVersion, the exception message for > unsupported protocol needs a space. > > ProtocolVersion pv = ProtocolVersion.nameOf(pn); > if (pv == null) { > throw new IllegalArgumentException( >

RFR: 8282932: a space is needed for the unsupported protocol exception message in ProtocolVersion

2022-03-09 Thread John Jiang
In class sun.security.ssl.ProtocolVersion, the exception message for unsupported protocol needs a space. ProtocolVersion pv = ProtocolVersion.nameOf(pn); if (pv == null) { throw new IllegalArgumentException( "Unsupported protocol" + pn); } - Commit messages: -

Re: RFR: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive [v2]

2022-03-09 Thread Sibabrata Sahoo
> Domain value for system property jdk.https.negotiate.cbt is case-insensitive > now. Included Test has been updated to address the change. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: Update HttpsCB.java -

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-09 Thread Joe Wang
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 For the bundles in java.xml: For files with Oracle copyright, update the year to 2022 and @LastModified Mar 2022. Take XPATHErrorResources_ja.java as an example, the copyright year was updated to 2021 and

Re: RFR: 8267319: Use larger default key sizes and algorithms based on CNSA [v4]

2022-03-09 Thread Valerie Peng
> It's been several years since we increased the default key sizes. Before > shifting to PQC, NSA replaced its Suite B cryptography recommendations with > the Commercial National Security Algorithm Suite which suggests: > > - SHA-384 for secure hashing > - AES-256 for symmetric encryption > -

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-09 Thread Naoto Sato
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 `src/java.base/share/classes/sun/util/resources/CurrencyNames_de.properties` `src/java.base/share/classes/sun/util/resources/CurrencyNames_ja.properties`

Re: RFR: 8267319: Use larger default key sizes and algorithms based on CNSA [v3]

2022-03-09 Thread Valerie Peng
On Wed, 9 Mar 2022 19:44:39 GMT, Weijun Wang wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update JarSigner javadoc to make it consistent with previous update > >

RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-09 Thread Alisen Chung
msg drop for jdk19, Mar 9, 2022 - Commit messages: - open jdk19 l10n msg drop Changes: https://git.openjdk.java.net/jdk/pull/7765/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7765=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280400 Stats: 13775 lines in 142

Re: RFR: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary

2022-03-09 Thread Bradford Wetmore
On Wed, 2 Mar 2022 19:04:26 GMT, zzambers wrote: > When testing compatibility of jdk TLS implementation with gnutls, I have > found a problem. The problem is, that gnutls does not like use of > user_canceled alert when closing TLS-1.3 connection from duplexCloseOutput() > (used by

Re: RFR: 8267319: Use larger default key sizes and algorithms based on CNSA [v3]

2022-03-09 Thread Weijun Wang
On Wed, 9 Mar 2022 19:15:36 GMT, Valerie Peng wrote: >> It's been several years since we increased the default key sizes. Before >> shifting to PQC, NSA replaced its Suite B cryptography recommendations with >> the Commercial National Security Algorithm Suite which suggests: >> >> - SHA-384

Re: RFR: 8267319: Use larger default key sizes and algorithms based on CNSA [v3]

2022-03-09 Thread Valerie Peng
> It's been several years since we increased the default key sizes. Before > shifting to PQC, NSA replaced its Suite B cryptography recommendations with > the Commercial National Security Algorithm Suite which suggests: > > - SHA-384 for secure hashing > - AES-256 for symmetric encryption > -

Integrated: 8282884: Provide OID aliases for MD2, MD5, and OAEP

2022-03-09 Thread Weijun Wang
On Wed, 9 Mar 2022 16:04:02 GMT, Weijun Wang wrote: > Add missing OID aliases for several algorithms. This pull request has now been integrated. Changeset: 70318e1d Author:Weijun Wang URL: https://git.openjdk.java.net/jdk/commit/70318e1d17072198be5674ebe7118fb5f9373144 Stats: 8

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v4]

2022-03-09 Thread Xue-Lei Andrew Fan
On Tue, 8 Mar 2022 15:03:57 GMT, zzambers wrote: >> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was >> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / >> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() >> performed

Re: RFR: 8267319: Use larger default key sizes and algorithms based on CNSA [v2]

2022-03-09 Thread Weijun Wang
On Wed, 9 Mar 2022 02:02:51 GMT, Valerie Peng wrote: >> It's been several years since we increased the default key sizes. Before >> shifting to PQC, NSA replaced its Suite B cryptography recommendations with >> the Commercial National Security Algorithm Suite which suggests: >> >> - SHA-384

Re: RFR: 8282884: Provide OID aliases for MD2, MD5, and OAEP

2022-03-09 Thread Xue-Lei Andrew Fan
On Wed, 9 Mar 2022 16:04:02 GMT, Weijun Wang wrote: > Add missing OID aliases for several algorithms. It looks good to me. - Marked as reviewed by xuelei (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7761

Integrated: 8280494: (D)TLS signature schemes

2022-03-09 Thread Xue-Lei Andrew Fan
On Thu, 27 Jan 2022 22:06:21 GMT, Xue-Lei Andrew Fan wrote: > This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE:

Re: RFR: 8282662: Use List/Set.of() factory methods to reduce memory consumption [v2]

2022-03-09 Thread liach
On Wed, 9 Mar 2022 08:35:45 GMT, Сергей Цыпанов wrote: >> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with >> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when >> called with vararg of size 0, 1, 2. >> >> In general replacement of

RFR: 8282884: Provide OID aliases for MD2, MD5, and OAEP

2022-03-09 Thread Weijun Wang
Add missing OID aliases for several algorithms. - Commit messages: - 8282884: Provide OID aliases for MD2, MD5, and OAEP Changes: https://git.openjdk.java.net/jdk/pull/7761/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7761=00 Issue:

Re: RFR: 8282662: Use List/Set.of() factory methods to reduce memory consumption [v2]

2022-03-09 Thread liach
On Wed, 9 Mar 2022 09:37:30 GMT, Сергей Цыпанов wrote: >> src/java.base/share/classes/java/nio/file/FileTreeIterator.java line 70: >> >>> 68: throws IOException >>> 69: { >>> 70: this.walker = new FileTreeWalker(List.of(options), maxDepth); >> >> Relates to

RFR: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive

2022-03-09 Thread Sibabrata Sahoo
Domain value for system property jdk.https.negotiate.cbt is case-insensitive now. Included Test has been updated to address the change. - Commit messages: - 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive Changes:

Re: RFR: 8280494: (D)TLS signature schemes [v20]

2022-03-09 Thread Sean Mullan
On Wed, 9 Mar 2022 08:25:48 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE:

Re: RFR: 8282662: Use List/Set.of() factory methods to reduce memory consumption [v2]

2022-03-09 Thread Сергей Цыпанов
On Tue, 8 Mar 2022 14:27:23 GMT, liach wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8282662: Revert dubious changes > > src/java.base/share/classes/java/nio/file/FileTreeIterator.java line 70: > >> 68:

Re: RFR: 8282662: Use List/Set.of() factory methods to reduce memory consumption [v2]

2022-03-09 Thread Сергей Цыпанов
On Tue, 8 Mar 2022 14:28:00 GMT, liach wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8282662: Revert dubious changes > > src/java.base/share/classes/sun/reflect/annotation/AnnotationSupport.java > line 79: >

Re: RFR: 8282662: Use List/Set.of() factory methods to reduce memory consumption [v2]

2022-03-09 Thread Сергей Цыпанов
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with > smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when > called with vararg of size 0, 1, 2. > > In general replacement of `Arrays.asList()` with `List.of()` is dubious as > the latter is

Re: RFR: 8280494: (D)TLS signature schemes [v19]

2022-03-09 Thread Xue-Lei Andrew Fan
On Tue, 8 Mar 2022 16:13:08 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add test for DTLS > > src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 501: > >> 499: >>

Re: RFR: 8280494: (D)TLS signature schemes [v20]

2022-03-09 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 > Release-note: