Re: RFR: 8209038: Clarify the javadoc of Cipher.getParameters()

On Wed, 6 Apr 2022 19:48:04 GMT, Valerie Peng wrote: >> src/java.base/share/classes/javax/crypto/Cipher.java line 1053: >> >>> 1051: * If this cipher has been previously initialized with >>> parameters, >>> 1052: * this method returns the same parameters. Otherwise, this >>> method

Re: RFR: 8209038: Clarify the javadoc of Cipher.getParameters()

On Wed, 6 Apr 2022 19:41:28 GMT, Xue-Lei Andrew Fan wrote: >> Can you be more specific like which block of code that you are referring to >> as the filtering and modification? >> I'd expect the intention is to use the parameter specified. Otherwise an >> exception should be thrown if the

Re: RFR: 8209038: Clarify the javadoc of Cipher.getParameters()

On Mon, 11 Apr 2022 15:20:22 GMT, Sean Mullan wrote: >> Anyone can help review this javadoc update? The main change is the wording >> for the method javadoc of >> Cipher.getParameters()/CipherSpi.engineGetParameters(). The original wording >> is somewhat restrictive and request is to broaden

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec

On 4/11/2022 9:34 PM, Valerie Peng wrote: This trivial change is to deprecate the DEFAULT static field of OAEPParameterSpec class. Wordings are mostly the same as the previous PSSParameterSpec deprecation change. Rest are just minor code re-factoring. The CSR will be filed once review is

RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec

This trivial change is to deprecate the DEFAULT static field of OAEPParameterSpec class. Wordings are mostly the same as the previous PSSParameterSpec deprecation change. Rest are just minor code re-factoring. The CSR will be filed once review is somewhat finished. Thanks, Valerie

Re: RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss

On Tue, 8 Mar 2022 17:21:34 GMT, Mark Powers wrote: > https://bugs.openjdk.java.net/browse/JDK-8284688 > > [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the > umbrella bug for this bug. The changes were too large for a single code > review, so it was decided to split into

RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss

https://bugs.openjdk.java.net/browse/JDK-8284688 [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the umbrella bug for this bug. The changes were too large for a single code review, so it was decided to split into smaller chunks. This is one such chunk:

Re: Proposal: Extend Windows KeyStore support to include access to the local machine location

Added a comment and assigned the enhancement to you. Thanks. --Weijun > On Apr 11, 2022, at 5:02 PM, Mat Carter wrote: > > Thanks, Weijun > > Let's move ahead with the two new strings while we consider read-only access. > As the current assignee can you update the JBS issue [1] with what

Re: Proposal: Extend Windows KeyStore support to include access to the local machine location

Thanks, Weijun Let's move ahead with the two new strings while we consider read-only access. As the current assignee can you update the JBS issue [1] with what we've agreed here. I have an implementation that I've been testing in 11u which can easily move to tip; if you are happy for me to

Re: RFR: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary

On Wed, 2 Mar 2022 19:04:26 GMT, zzambers wrote: > When testing compatibility of jdk TLS implementation with gnutls, I have > found a problem. The problem is, that gnutls does not like use of > user_canceled alert when closing TLS-1.3 connection from duplexCloseOutput() > (used by

Re: Proposal: Extend Windows KeyStore support to include access to the local machine location

Hello, if you can open/target specific stores dynamically it is up to the developer/user what they do with it (very similar to keystore files). Addressbook in my post was only an example (but a good one: imagine Java app wants to import the addressbook entries) Gruss Bernd --

Re: Proposal: Extend Windows KeyStore support to include access to the local machine location

Sorry for the late reply. Yes, your suggestions are good. We can support "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE". For read-only access to the keystores, we have already allowed writing and this probably will not change. If we do want to support read-only later, it could be a

Re: Proposal: Extend Windows KeyStore support to include access to the local machine location

Hi Weijun Did my answers address your concerns? Also do you have an opinion on Bernd's suggestion? Thanks in advance Mat Sent from Outlook From: security-dev on behalf of Bernd Eckenfels Sent: Tuesday, April 5, 2022 11:20 AM To:

Integrated: 8284105: Update security libraries to use sealed classes

On Fri, 8 Apr 2022 13:40:37 GMT, Sean Mullan wrote: > Please review these changes to update the security libraries to use sealed > classes. See JEP 409 for more details on sealed classes. > > No CSR is required as all the changes are to internal classes. A few classes > that did not have

Re: RFR: 8209038: Clarify the javadoc of Cipher.getParameters()

On Wed, 6 Apr 2022 00:14:04 GMT, Valerie Peng wrote: > Anyone can help review this javadoc update? The main change is the wording > for the method javadoc of > Cipher.getParameters()/CipherSpi.engineGetParameters(). The original wording > is somewhat restrictive and request is to broaden this

Re: RFR: 8284490: Remove finalizer method in java.security.jgss [v4]

On Sat, 9 Apr 2022 06:19:12 GMT, Xue-Lei Andrew Fan wrote: >> Please review the update to remove finalizer method in the >> java.security.jgss module. It is one of the efforts to clean up the use of >> finalizer method in JDK. > > Xue-Lei Andrew Fan has updated the pull request with a new

Re: RFR: 8284105: Update security libraries to use sealed classes [v3]

> Please review these changes to update the security libraries to use sealed > classes. See JEP 409 for more details on sealed classes. > > No CSR is required as all the changes are to internal classes. A few classes > that did not have subclasses were simply marked final instead of sealed.

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v24]

On Mon, 11 Apr 2022 10:33:54 GMT, David Holmes wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix TestLinkToNativeRBP > > src/hotspot/share/prims/scopedMemoryAccess.cpp line 141: > >> 139: >> 140: /* >>

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v24]

On Mon, 4 Apr 2022 14:57:30 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-424 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] -

Integrated: 8284641: Doc errors in sun.security.ssl.SSLSessionContextImpl

On Mon, 11 Apr 2022 04:02:44 GMT, John Jiang wrote: > JDK-8228396 turned stateless resumption on by default, but the JavaDoc was > not modified accordingly. > And a "{" is missing for @systemProperty > jdk.tls.server.enableSessionTicketExtension. This pull request has now been integrated.

Re: RFR: 8284641: Doc errors in sun.security.ssl.SSLSessionContextImpl

On Mon, 11 Apr 2022 04:02:44 GMT, John Jiang wrote: > JDK-8228396 turned stateless resumption on by default, but the JavaDoc was > not modified accordingly. > And a "{" is missing for @systemProperty > jdk.tls.server.enableSessionTicketExtension. Marked as reviewed by ssahoo (Committer).