On Thu, 14 Apr 2022 18:08:21 GMT, Xue-Lei Andrew Fan wrote:
>> The log for Finished message looks like the below,
>>
>> "Finished": {
>> "verify data": {
>> : ... ...
>> }'} // looks weird
>>
>> because a line feed is missing in the format pattern.
>>
>> ""Finished": '{'\n" +
>>
On Wed, 13 Apr 2022 05:10:22 GMT, John Jiang wrote:
> The log for Finished message looks like the below,
>
> "Finished": {
> "verify data": {
> : ... ...
> }'} // looks weird
>
> because a line feed is missing in the format pattern.
>
> ""Finished": '{'\n" +
> " "verify data":
On Wed, 13 Apr 2022 22:04:03 GMT, Valerie Peng wrote:
>> Anyone can help review this javadoc update? The main change is the wording
>> for the method javadoc of
>> Cipher.getParameters()/CipherSpi.engineGetParameters(). The original wording
>> is somewhat restrictive and request is to broaden
> https://bugs.openjdk.java.net/browse/JDK-8284688
>
> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the
> umbrella bug for this bug. The changes were too large for a single code
> review, so it was decided to split into smaller chunks. This is one such
> chunk:
>
>
On Thu, 14 Apr 2022 22:01:55 GMT, Xue-Lei Andrew Fan wrote:
>> This is an effort to fix a problem introduced in the fix for
>> [JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which
>> replaced the finalizers in jdk.crypto.cryptoki with Cleaners. However,
>> there is a
On Thu, 14 Apr 2022 19:26:53 GMT, Daniel Fuchs wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> use static cleaner, and clean up swp file
>
>
> This is an effort to fix a problem introduced in the fix for
> [JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which
> replaced the finalizers in jdk.crypto.cryptoki with Cleaners. However, there
> is a problem with the code changes. The Runnables registered with Cleaner
>
On Thu, 14 Apr 2022 19:22:00 GMT, Valerie Peng wrote:
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/.PKCS11.java.swp
> file should not be there?
Oops, I missed this swp file while using git commit.
-
PR: https://git.openjdk.java.net/jdk/pull/8248
On Thu, 14 Apr 2022 19:56:22 GMT, Bradford Wetmore wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add `@LastModified: Apr 2022` to DocumentCache
>
>
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
java.xml.crypto's usage downgrade grammar to 1.8
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
-
On Thu, 14 Apr 2022 21:05:06 GMT, Daniel Jeliński wrote:
>> During TLS handshake, hundreds of constraints are evaluated to determine
>> which cipher suites are usable. Most of the evaluations are performed using
>> `HandshakeContext#algorithmConstraints` object. By default that object
>>
> During TLS handshake, hundreds of constraints are evaluated to determine
> which cipher suites are usable. Most of the evaluations are performed using
> `HandshakeContext#algorithmConstraints` object. By default that object
> contains a `SSLAlgorithmConstraints` instance wrapping another
>
On Thu, 14 Apr 2022 18:32:03 GMT, Naoto Sato wrote:
>>> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
>>
>> @stuart-marks @naotoj I can help solve JDK-8284856 after this pr. But
>> usually we only solve 1 issue in 1 pr, so I think it's better to wait after
>>
On Thu, 14 Apr 2022 19:53:45 GMT, Bradford Wetmore wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add `@LastModified: Apr 2022` to DocumentCache
>
> I learned something new about HashMap today...
>
> I looked at
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.base` directory, and accepted those
> changes where it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> The majority of fixes are in
On Thu, 14 Apr 2022 20:11:37 GMT, XenoAmess wrote:
> > Are the changes necessary for this part?
>
> @seanjmullan no, they are just performance refinement.
>
> If you really that wanna 100% sync ,
>
> I can use the old 1.8 api to migrate that part, and make a mirror pr to that
> part of
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
> Are the changes
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.base` directory, and accepted those
> changes where it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> The majority of fixes are in
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
I learned something new
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
Right, we generally try to
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.base` directory, and accepted those
> changes where it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> The majority of fixes are in
On Wed, 13 Apr 2022 19:27:00 GMT, Valerie Peng wrote:
>> This trivial change is to deprecate the DEFAULT static field of
>> OAEPParameterSpec class. Wordings are mostly the same as the previous
>> PSSParameterSpec deprecation change. Rest are just minor code re-factoring.
>>
>> The CSR will
On Thu, 14 Apr 2022 18:06:10 GMT, Xue-Lei Andrew Fan wrote:
> This is an effort to fix a problem introduced in the fix for
> [JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which
> replaced the finalizers in jdk.crypto.cryptoki with Cleaners. However, there
> is a problem
I ran `codespell` on the `src/java.base` directory, and accepted those changes
where it indeed discovered real typos.
(Due to false positives this can unfortunately not be run automatically)
The majority of fixes are in comments. A handful is in strings, one in a local
variable name, and a
On Thu, 14 Apr 2022 18:06:10 GMT, Xue-Lei Andrew Fan wrote:
> This is an effort to fix a problem introduced in the fix for
> [JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which
> replaced the finalizers in jdk.crypto.cryptoki with Cleaners. However, there
> is a problem
On Thu, 14 Apr 2022 17:06:53 GMT, XenoAmess wrote:
>> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
>
>> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
>
> @stuart-marks @naotoj I can help solve JDK-8284856 after this pr. But usually
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
Marked as reviewed by
On Thu, 14 Apr 2022 18:05:48 GMT, XenoAmess wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java
>> line 3:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights
>>> reserved.
>>> 3: */
>>
>> The LastModified
This is an effort to fix a problem introduced in the fix for
[JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which replaced
the finalizers in jdk.crypto.cryptoki with Cleaners. However, there is a
problem with the code changes. The Runnables registered with Cleaner refer to
On Wed, 13 Apr 2022 05:10:22 GMT, John Jiang wrote:
> The log for Finished message looks like the below,
>
> "Finished": {
> "verify data": {
> : ... ...
> }'} // looks weird
>
> because a line feed is missing in the format pattern.
>
> ""Finished": '{'\n" +
> " "verify data":
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
add `@LastModified: Apr 2022` to DocumentCache
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
-
On Thu, 14 Apr 2022 17:23:42 GMT, Joe Wang wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert changes on ProcessEnvironment
>
>
On Thu, 14 Apr 2022 10:38:33 GMT, Yi Yang wrote:
>I found [yet another
>typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948),
> I wonder if you can merge this into your patch so that I do not need to
>submit a new PR for it? Thanks.
I think it deserves a
On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov wrote:
> Found various typos of expected: `exepected`, `exept`, `epectedly`,
> `expeced`, `Unexpeted`, etc.
This pull request has now been integrated.
Changeset: 48c75498
Author:Andrey Turbanov
URL:
On Thu, 14 Apr 2022 17:05:39 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes on ProcessEnvironment
On Wed, 13 Apr 2022 22:53:15 GMT, Naoto Sato wrote:
> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
@stuart-marks @naotoj I can help solve JDK-8284856 after this pr. But usually
we only solve 1 issue in 1 pr, so I think it's better to wait after this.
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
revert changes on ProcessEnvironment
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
- new:
On Wed, 13 Apr 2022 23:25:47 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update LastModified
>
> src/java.base/unix/classes/java/lang/ProcessEnvironment.java line 102:
>
>> 100: /* Only for
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
fix usage in XSAttributeChecker
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
- new:
On Thu, 14 Apr 2022 03:38:52 GMT, Joe Wang wrote:
>>> I suspect the `size*2+1` was a failed attempt at allocating a HashMap of
>>> the correct capacity for `size` mappings.
>>
>> I looked the codes and don't think so..
>> If I'm wrong, I'm glad to fix.
>
> Stuart's right, I looked at the code,
On Thu, 14 Apr 2022 15:53:53 GMT, Xue-Lei Andrew Fan wrote:
>> as of today, this method is never called with a `null` argument
>> (`SSLConfiguration#userSpecifiedAlgorithmConstraints` is initialized to
>> `DEFAULT` and cannot be reset to `null`), but I can add a null check for
>>
On Thu, 14 Apr 2022 15:43:42 GMT, Daniel Jeliński wrote:
>>> @XueleiFan did you mean `||` (not `&&`) ?
>>
>> Thank you @dfuch. Yes, it should be "||".
>
> as of today, this method is never called with a `null` argument
> (`SSLConfiguration#userSpecifiedAlgorithmConstraints` is initialized to
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
LGTM.
-
Marked as reviewed by chegar
On Thu, 14 Apr 2022 14:58:24 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java
>> line 73:
>>
>>> 71:
>>> 72: static AlgorithmConstraints wrap(AlgorithmConstraints
>>> userSpecifiedConstraints) {
>>> 73: if
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
On Wed, 13 Apr 2022 07:14:04 GMT, John Jiang wrote:
> Could I not change this style?
Sure. But effort of this update will be overrode if text blocks are used. I
would suggest to use text block once the code block get touched.
-
PR: https://git.openjdk.java.net/jdk/pull/8215
On Thu, 14 Apr 2022 04:24:07 GMT, Xue-Lei Andrew Fan wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid nesting SSLAlgorithmConstraints
>
>
On Thu, 14 Apr 2022 09:28:17 GMT, Andrey Turbanov wrote:
>> Found various typos of expected: `exepected`, `exept`, `epectedly`,
>> `expeced`, `Unexpeted`, etc.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8284853:
On Thu, 14 Apr 2022 09:28:17 GMT, Andrey Turbanov wrote:
>> Found various typos of expected: `exepected`, `exept`, `epectedly`,
>> `expeced`, `Unexpeted`, etc.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8284853:
> Found various typos of expected: `exepected`, `exept`, `epectedly`,
> `expeced`, `Unexpeted`, etc.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8284853: Fix various 'expected' typo
improve test log
-
Changes:
On Thu, 14 Apr 2022 04:24:07 GMT, Xue-Lei Andrew Fan wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid nesting SSLAlgorithmConstraints
>
>
On Wed, 13 Apr 2022 19:28:08 GMT, Stuart Marks wrote:
> Reviewers for i18n, net, nio, and security, please review call site changes
> in your areas. Thanks.
Changes to `java.net.http` look good to me. I haven't spotted anything
obviously wrong in the rest, but should defer to reviewers of
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
53 matches
Mail list logo
